Update JSON Patch Functionality #15430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Patch operations contained in the document
…, added support for null in add, replace, and test operations
srnagar
approved these changes
Sep 23, 2020
...core-experimental/src/main/java/com/azure/core/experimental/jsonpatch/JsonPatchDocument.java
Outdated
Show resolved
Hide resolved
srnagar
approved these changes
Sep 23, 2020
…g external dependencies in public API
pakrym
reviewed
Sep 23, 2020
...core-experimental/src/main/java/com/azure/core/experimental/jsonpatch/JsonPatchDocument.java
Show resolved
Hide resolved
|
AFAIK You have a bunch of JSON DOM interfaces in core, do we want to take those as well? |
Is this in reference to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates JSON Patch functionality in
azure-core-experimental.JsonPatchDocumentto accept aJsonSerializerduring construction of the class.valueparameters from JSONified strings to Object.valueparameters to allow for a JSON null to be serialized as the value to support all scenarios in JSON Patch.JsonPatchDocumentSerializerandJsonPatchOperationSerializerto handle serialization ofJsonPatchDocumentandJsonPatchOperation.JsonPatchOperationandJsonPatchOperationKindpublic.getJsonPatchOperationstoJsonPatchDocumentto get a read only list of operations in the document.