[Event Hubs] Canary support for live tests #15345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
reviewed
Sep 25, 2020
| matrix: | ||
| ${{ insert }}: ${{ parameters.Matrix }} | ||
| ${{ if eq(parameters.TestCanary, 'true') }}: | ||
| Linux - Java 8 (AzureCloudCanary): |
There was a problem hiding this comment.
I would probably add a Java 11 run instead of 8.
There was a problem hiding this comment.
Thanks. Updated as suggested and triggered the pipeline again.. let me know if that's good.
weshaggard
approved these changes
Sep 25, 2020
weshaggard
approved these changes
Sep 26, 2020
weshaggard
reviewed
Sep 26, 2020
| OSVmImage: 'ubuntu-18.04' | ||
| JavaTestVersion: '1.11' | ||
| DisplayName: 'Linux - Java 11' | ||
| SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources-preview) |
There was a problem hiding this comment.
As an aside for Canary should we be using the "-preview" or the "-dogfood" subscription
There was a problem hiding this comment.
@danieljurek suggested '-preview' for special cases like this since we shouldn't disturb the main (normal) subscription with new/more permissions. We haven't talked about '-dogfood' subscription, I'll leave it to you to decide.
There was a problem hiding this comment.
If this is only about enabling preview feature flags then we should be OK with using "-preview".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last triggered pipeline - https://dev.azure.com/azure-sdk/internal/_build/results?buildId=553345&view=results
More relevant info - Azure/azure-sdk-for-js#11318