[Event Hubs] Support SAS token in connnection string #14912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YijunXieMS
reviewed
Sep 8, 2020
...e-core-amqp/src/main/java/com/azure/core/amqp/implementation/ConnectionStringProperties.java
Outdated
Show resolved
Hide resolved
...e-core-amqp/src/main/java/com/azure/core/amqp/implementation/ConnectionStringProperties.java
Outdated
Show resolved
Hide resolved
...e-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubClientBuilder.java
Show resolved
Hide resolved
conniey
approved these changes
Sep 8, 2020
A few comments
...e-core-amqp/src/main/java/com/azure/core/amqp/implementation/ConnectionStringProperties.java
Outdated
Show resolved
Hide resolved
...e-core-amqp/src/main/java/com/azure/core/amqp/implementation/ConnectionStringProperties.java
Show resolved
Hide resolved
...e-core-amqp/src/main/java/com/azure/core/amqp/implementation/ConnectionStringProperties.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/azure/messaging/eventhubs/implementation/EventHubSharedKeyCredential.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/azure/messaging/eventhubs/implementation/EventHubSharedKeyCredential.java
Show resolved
Hide resolved
YijunXieMS
approved these changes
Sep 8, 2020
|
/check-enforcer override |
|
/check-enforcer evaluate |
conniey
pushed a commit
to conniey/azure-sdk-for-java
that referenced
this pull request
Sep 11, 2020
* Move load balancing options changes to main branch * Support SAS token in connnection string
conniey
added a commit
that referenced
this pull request
Sep 11, 2020
* [Event Hubs] Support SAS token in connnection string (#14912) * Move load balancing options changes to main branch * Support SAS token in connnection string * Update to release version 1.5.1 * Update CHANGELOG and README. Co-authored-by: Srikanta <51379715+srnagar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to include SharedAccessSignature token in the connection string.
More details and discussion can be found here: Azure/azure-sdk#1701