Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Make azure-spring-boot-starter-active-directory support work together with other oauth2 provider(like google) #23265

Closed
1 task done
chenrujun opened this issue Jul 30, 2021 · 2 comments
Assignees
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@chenrujun
Copy link

chenrujun commented Jul 30, 2021

For example, support config like this:

spring.security.oauth2.client.registration.google.client-id=${CONFIG_GOOGLE_CLIENTID}
spring.security.oauth2.client.registration.google.client-secret=${CONFIG_GOOGLE_CLIENTSECRET}

spring.security.oauth2.client.registration.azure.client-id=${CONFIG_AZURE_CLIENTID}
spring.security.oauth2.client.registration.azure.client-secret=${CONFIG_AZURE_CLIENTSECRET}
azure.activedirectory.tenant-id=${CONFIG_AZURE_TENANTID}
azure.activedirectory.user-group.allowed-groups=${CONFIG_AZURE_ALLOWEDGROUPS}

Then google and azure can work together.

Tasks

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 30, 2021
@chenrujun chenrujun self-assigned this Jul 30, 2021
@chenrujun chenrujun added this to the Backlog milestone Jul 30, 2021
@joshfree joshfree added azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. labels Jul 30, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 30, 2021
@chenrujun
Copy link
Author

Relation issue: #23710

@chenrujun
Copy link
Author

Closing this issue, because we already decide to deprecate azure-spring-boot-starter-active-directory. Use this repo to demonstrate how to use Azure Active Directory in Spring Boot application: https://github.com/Azure-Samples/spring-boot-application-with-azure-active-directory

Repository owner moved this from Todo to Done in Spring Cloud Azure Nov 5, 2021
@chenrujun chenrujun modified the milestones: Backlog, [2021] November Nov 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Archived in project
Development

No branches or pull requests

2 participants