Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete beans which should not configured in azure-spring-cloud-autoconfigure #23942

Closed
Tracked by #23402 ...
chenrujun opened this issue Sep 7, 2021 · 1 comment · Fixed by #24280
Closed
Tracked by #23402 ...

Delete beans which should not configured in azure-spring-cloud-autoconfigure #23942

chenrujun opened this issue Sep 7, 2021 · 1 comment · Fixed by #24280
Assignees
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@chenrujun
Copy link

  • AADWebApplicationConfiguration
    • OAuth2UserService: User may be confused when he configured AADOAuth2UserService but he want to map roles into authorities.
    • OAuth2AuthorizedClientManager we should let customer define this. If we did this, customer will be confused if he want to use password login and oboProvider.
  • AADResourceServerConfiguration
    • JwtDecoder: If user configured his own JwtDecoder, a lot if features we provided will not work, which will make user confused. Furthermore, seems all resource-server feature can be done by spring-security natively.
    • DefaultAADResourceServerWebSecurityConfigurerAdapter. This should be configured by customer himself. For example, user want to use web-application and resource-server in one application.
  • AADOAuth2ClientConfiguration
@chenrujun chenrujun added Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. labels Sep 7, 2021
@chenrujun chenrujun added this to the [2021] October milestone Sep 7, 2021
@chenrujun chenrujun self-assigned this Sep 7, 2021
@chenrujun chenrujun changed the title Delete beans which should not configured in azure-spring-cloud-autoconfigure [Azure Spring Security] Delete beans which should not configured in azure-spring-cloud-autoconfigure Sep 26, 2021
@chenrujun chenrujun changed the title [Azure Spring Security] Delete beans which should not configured in azure-spring-cloud-autoconfigure [Spring Security] Delete beans which should not configured in azure-spring-cloud-autoconfigure Sep 26, 2021
@chenrujun chenrujun changed the title [Spring Security] Delete beans which should not configured in azure-spring-cloud-autoconfigure [Security] Delete beans which should not configured in azure-spring-cloud-autoconfigure Sep 26, 2021
@chenrujun chenrujun changed the title [Security] Delete beans which should not configured in azure-spring-cloud-autoconfigure [Azure AD] Delete beans which should not configured in azure-spring-cloud-autoconfigure Sep 26, 2021
@chenrujun chenrujun changed the title [Azure AD] Delete beans which should not configured in azure-spring-cloud-autoconfigure Delete beans which should not configured in azure-spring-cloud-autoconfigure Sep 26, 2021
@chenrujun chenrujun changed the title Delete beans which should not configured in azure-spring-cloud-autoconfigure Implement azure-spring-security-oauth 4.0 Sep 28, 2021
@chenrujun chenrujun changed the title Implement azure-spring-security-oauth 4.0 Delete beans which should not configured in azure-spring-cloud-autoconfigure Sep 28, 2021
@chenrujun
Copy link
Author

Closing this issue because related PR has been merged.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
1 participant