Adding a Template to help guide new PRs. #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a lot of submissions to the `master` branch, which will get immediately released to folks using `go get` for that reason, we want to always make sure that `master` stays in release quality.
|
@marstr How about including that the PR links to the issue it fixes and that the change description contains an adequate summary of the fix? So many times we get PRs with very little context. |
|
Change made, @jhendrixMSFT :) |
jhendrixMSFT
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of submissions to the
masterbranch, which will getimmediately released to folks using
go getfor that reason, we want toalways make sure that
masterstays in release quality.