Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating travis build check to be global. #814

Closed
wants to merge 1 commit into from

Conversation

marstr
Copy link
Member

@marstr marstr commented Oct 15, 2017

No description provided.

@marstr
Copy link
Member Author

marstr commented Oct 15, 2017

I'm going to abandon this PR and instead submit another where we use a makefile, the approach can be seen here in @devigned's project: https://github.com/devigned.veil/Makefile

The advantage of doing it this way would be two fold:

  1. Allow us to write the rules in such a way that only relevant information is spit out in the CI log, also skipping irrelevant tests depending on the environment.
  2. Mac/Linux users will be able to run the tests as if they were executing in Travis simply by running make. Windows users will not be impacted by this change either for the better or worse.

@marstr marstr closed this Oct 15, 2017
@marstr marstr deleted the cleanupTravis branch November 6, 2017 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant