Draft PR for Snapshots #22069
Draft PR for Snapshots #22069
Conversation
MBSolomon
commented
Nov 29, 2023
- The purpose of this PR is explained in this or a referenced issue.
- The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
- Tests are included and/or updated for code changes.
- Updates to module CHANGELOG.md are included.
- MIT license headers are included in each file.
|
|
||
| return ListSnapshotsPagerResponse{ | ||
| Snapshots: ss, | ||
| SyncToken: SyncToken(*page.SyncToken), |
There was a problem hiding this comment.
Is it possible for SyncToken to be nil?
There was a problem hiding this comment.
The service will provide a Sync-Token header in each response: https://learn.microsoft.com/en-us/azure/azure-app-configuration/rest-api-consistency#response
|
LRO recordings blocked on #22102 |
| @@ -76,3 +76,119 @@ type SetSettingOptions struct { | |||
| // if the passed-in ETag is the same version as the one in the configuration store. | |||
| OnlyIfUnchanged *azcore.ETag | |||
| } | |||
|
|
|||
| type BeginCreateSnapshotOptions struct { | |||
There was a problem hiding this comment.
Missing doc comment (applies to other new types in this file).
| Created *time.Time | ||
|
|
||
| // READ-ONLY; A value representing the current state of the snapshot. | ||
| Etag *string |
There was a problem hiding this comment.
This should be named ETag and use the type from azcore.
| @@ -78,3 +79,70 @@ type SetSettingResponse struct { | |||
| // SyncToken contains the value returned in the Sync-Token header. | |||
| SyncToken SyncToken | |||
| } | |||
| type ArchiveSnapshotResponse struct { | |||
There was a problem hiding this comment.
Missing doc comment (applies to other new response types in this file).
| @@ -78,3 +79,70 @@ type SetSettingResponse struct { | |||
| // SyncToken contains the value returned in the Sync-Token header. | |||
| SyncToken SyncToken | |||
| } | |||
| type ArchiveSnapshotResponse struct { | |||
| generated.Snapshot | |||
There was a problem hiding this comment.
I don't think we want to directly expose the generated type. I presume we'll want to define a Snapshot type (similar to how we did for Setting) so it can have the shape we want.
| Link *string | ||
|
|
||
| // SyncToken contains the information returned from the Sync-Token header response. | ||
| SyncToken *string |
There was a problem hiding this comment.
Since a response always contains a sync token, these don't need to be pointer-to-type.
| generated.Snapshot | ||
|
|
||
| // Link contains the information returned from the Link header response. | ||
| Link *string |
There was a problem hiding this comment.
something in this format:
"</kv?snapshot=&api-version=2023-10-01>; rel="items""
There was a problem hiding this comment.
internal@v1.5.1 is now available. You can pick that up and rebase so these changes evaporate.
|
Closing in favor of #22118 |