Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return AccessToken by value #17836

Merged
merged 2 commits into from
May 6, 2022
Merged

Return AccessToken by value #17836

merged 2 commits into from
May 6, 2022

Conversation

jhendrixMSFT
Copy link
Member

Returning by pointer is cruft from an early design and not necessary.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@jhendrixMSFT
Return AccessToken by value
d9ebf57 
Returning by pointer is cruft from an early design and not necessary.
chlowell
chlowell approved these changes May 6, 2022
View reviewed changes
@jhendrixMSFT jhendrixMSFT merged commit a8723e0 into Azure:main May 6, 2022
@jhendrixMSFT jhendrixMSFT deleted the azcore_gettoken branch May 6, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft richardpark-msft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhendrixMSFT @chlowell