[KeyVault] KV Certificates Client Library #16853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run prepare-pipelines |
* updating azsecrets and azkeys * updating azkeys recordings
Fixing several reliability and recovery bugs that were affecting sending and receiving. This PR finally exports retry options so callers can configure how long and how many retries they want. The big changes: * Retry configuration options are now exposed through the ClientOptions for both the Admin client and the Service Bus client. * amqpLinks.go has it's own Retry mechanism, based on the azcore retry algorithm. This does exponential backoff, jitter and is configurable using Client.RetryOptions. This retry mechanism cleans up several areas that were doing the BackoffRetrier before. * MgmtClient is gone, and we just use rpcLink now. There were some coordination issues that just weren't working properly, so the rpc link code has been moved into azservicebus for now (it was always an internal type and remains so). * Sender/Receiver both use the better amqplinks.Retry() and their code has been structured to make that easier to read (hopefully!) Bug fixes: * Fixed a bug where the proper error wasn't being broadcast when the connection failed in rpc, preventing proper connection recovery. * Fixed a bug where links wouldn't properly recreate if the connection recovery happened in the claim negotiation. Fixes Azure#15170 (Connection/network recovery) Fixes Azure#15610 (Error handling needs work to be consistent and reliable) Fixes Azure#15642 (Unify all the various retry mechanisms) These were fixed by more or less sidestepping retryableRPC() mechanism: Fixes Azure#15644 (amqp-common's retryableRPC method returns string errors) Fixes Azure#16088 (amqp-common's link.RetryableRPC() retries an entity does not exist)
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* compatible with old SDK generation and new codegen automation
Co-authored-by: Dane Walton <dawalton@microsoft.com>
Poller.FinalResponse() wasn't restoring the response body after reading. Removed duplicate definitions from GetJSON and bodyDownloadPolicy.
benbp
added a commit
to benbp/azure-sdk-for-go
that referenced
this pull request
Jan 28, 2022
* generated code for azcerts * add readme and doc.go files * formatting, added BeginCreateCertificate, although not a poller yet * starting GetCertificate * adding GetCertificate endpoint * changed to a poller using GetCertificate, should be with GetCertificateOperation * adding GetCertificateOperation * added several more methods * adding list certs method * ListCertificates implementation, but test is not working yet * adding CreateIssuer method * adding GetIssuer * adding issuer pager * adding delete issuer method * doc updates and UpdateIssuer method * Adding contacts crud operations * adding Get and Update CertificatePolicy * adding UpdateCertificateProperties * Added BeginRecoverDeletedCert method * restore certificate backup * removing the poller.go file * adding list deleted certs func * last test * adding certificates to eng/config.json * removing generated from two public models * adding ci.yml file * trigger ci run * adding license file, format header, and running go fmt * adding examples and readme * adding delete and cancel operation funcs * error handling on examples * updating broken link * adding a changelog * changing Tags to map[string]string * updating comments, pagers * formatting * Only fetch provision application oid via API if not supplied (Azure#16878) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * More resilient updating of ExpiringResource (Azure#16789) * Sync eng/common directory with azure-sdk-tools for PR 2585 (Azure#16876) * updating to target test-proxy that only gets filename from body of /start request * update recording.go to send x-recording-file in body of /start request Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 2596 (Azure#16894) - Fix bug in Add-ReleaseLease helper script - Enable better local logging for handling token - Enable strict mode to help catch issues like this in the future * Sync eng/common directory with azure-sdk-tools for PR 2578 (Azure#16895) * excluding duplicated env:USER in image tag * NIT * removing default repo name Co-authored-by: Albert Cheng <albertcheng@microsoft.com> * renaming * Changes for AZURE_CLIENT_SEND_CERTIFICATE_CHAIN (Azure#16851) * add support for AZURE_CLIENT_SEND_CERTIFICATE_CHAIN * Update CHANGELOG.md (Azure#16903) * Update CHANGELOG.md * Update version * Update version.go * Increment version for internal releases (Azure#16905) Increment package version after release of internal * Sync eng/common directory with azure-sdk-tools for PR 2581 (Azure#16910) * Generate token for aad app. * Remove testing mode * Update Generate-AddToken.ps1 * Update Generate-AddToken.ps1 * Generate token inside of opensource API call scripts * Add resource * Address feedback * Update eng/common/scripts/Get-AADIdentityFromGithubUser.ps1 Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * Update eng/common/scripts/Get-AADIdentityFromGithubUser.ps1 Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * Remove the printout * Update eng/common/scripts/Get-AADIdentityFromGithubUser.ps1 Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Update eng/common/scripts/Get-AADIdentityFromGithubUser.ps1 Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * Added PS script strict mode * Update Get-AADIdentityFromGithubUser.ps1 * Update Get-AADIdentityFromGithubUser.ps1 Co-authored-by: sima-zhu <sizhu@microsoft.com> Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Syncing eng/common (Azure#16904) Co-authored-by: Albert Cheng <albertcheng@microsoft.com> * [Release] sdk/resourcemanager/storage/armstorage/0.4.0 generation from spec commit: d830271b241897bad300f9275ff7b27d502aa6c5 (Azure#16913) * [Tables] updating recordings for latest breaking change (Azure#16906) * updating recordings for latest breaking change * go mod tidy * reverting eng changes to docker tool instead of proxy direct * running docker dump twice * Update azidentity recordings (Azure#16912) * [KeyVault] Update recordings (Azure#16917) * updating azsecrets and azkeys * updating azkeys recordings * [azservicebus] Fixing several reliability/recovery bugs (Azure#16831) Fixing several reliability and recovery bugs that were affecting sending and receiving. This PR finally exports retry options so callers can configure how long and how many retries they want. The big changes: * Retry configuration options are now exposed through the ClientOptions for both the Admin client and the Service Bus client. * amqpLinks.go has it's own Retry mechanism, based on the azcore retry algorithm. This does exponential backoff, jitter and is configurable using Client.RetryOptions. This retry mechanism cleans up several areas that were doing the BackoffRetrier before. * MgmtClient is gone, and we just use rpcLink now. There were some coordination issues that just weren't working properly, so the rpc link code has been moved into azservicebus for now (it was always an internal type and remains so). * Sender/Receiver both use the better amqplinks.Retry() and their code has been structured to make that easier to read (hopefully!) Bug fixes: * Fixed a bug where the proper error wasn't being broadcast when the connection failed in rpc, preventing proper connection recovery. * Fixed a bug where links wouldn't properly recreate if the connection recovery happened in the claim negotiation. Fixes Azure#15170 (Connection/network recovery) Fixes Azure#15610 (Error handling needs work to be consistent and reliable) Fixes Azure#15642 (Unify all the various retry mechanisms) These were fixed by more or less sidestepping retryableRPC() mechanism: Fixes Azure#15644 (amqp-common's retryableRPC method returns string errors) Fixes Azure#16088 (amqp-common's link.RetryableRPC() retries an entity does not exist) * fix incidentally added path addition (Azure#16918) Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * sdk generation pipeline script (Azure#16782) * compatible with old SDK generation and new codegen automation * remove greedy suffix on link check (Azure#16922) Co-authored-by: Dane Walton <dawalton@microsoft.com> * remove (Azure#16919) * Use Payload() for reading response bodies (Azure#16911) Poller.FinalResponse() wasn't restoring the response body after reading. Removed duplicate definitions from GetJSON and bodyDownloadPolicy. * [azservicebus] Explicitly reference gin-gonic until nhooyr.io/websocket is updated Azure#16927 * return *Client * removing LRO and pager interfaces * all tests passing again * updating and fixing a couple bugs, newest autorest version * updating embedded models * formatting * updating to latest internal * adding to doc.go Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com> Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> Co-authored-by: Albert Cheng <albertcheng@microsoft.com> Co-authored-by: Christopher Scott <chriss@microsoft.com> Co-authored-by: sima-zhu <sizhu@microsoft.com> Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Jiahui Peng <46921893+Alancere@users.noreply.github.com> Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com> Co-authored-by: chunyu3 <chunyu@microsoft.com> Co-authored-by: Dane Walton <dawalton@microsoft.com> Co-authored-by: Joel Hendrix <jhendrix@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First preview of the Key Vault Certificates library