Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an error on nil response #14738

Closed
wants to merge 1 commit into from

Conversation

jhendrixMSFT
Copy link
Member

Properly handle the case where the HTTP client returns a nil response
and error.
Refactored poller.Poll() to simplify error propagation.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

Properly handle the case where the HTTP client returns a nil response
and error.
Refactored poller.Poll() to simplify error propagation.
@jhendrixMSFT
Copy link
Member Author

Fixes #14729

@jhendrixMSFT jhendrixMSFT marked this pull request as draft June 2, 2021 20:26
@jhendrixMSFT
Copy link
Member Author

There was a fix in azcore to return an error if the response and error were both nil. It could be the case that the repro was using an older version of azcore without the fix.

@jhendrixMSFT jhendrixMSFT deleted the armcore_nil_response branch December 10, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant