Bug(docs): armconnectedvmware docs example reference a non existing client

[erezrokah]

Bug Report

v1.0.0 of this package removed NewVirtualMachinesClient, see https://github.com/Azure/azure-sdk-for-go/blob/2621632e48ea508e16ce568001402f92fca4afa0/sdk/resourcemanager/connectedvmware/armconnectedvmware/CHANGELOG.md#100-2023-10-27

However it's still referenced from the docs https://github.com/Azure/azure-sdk-for-go/tree/2621632e48ea508e16ce568001402f92fca4afa0/sdk/resourcemanager/connectedvmware/armconnectedvmware#clients

• What happened?
  NewVirtualMachinesClient removed but still in docs
• What did you expect or want to happen?
  NewVirtualMachinesClient not removed or removed from docs
• How can we reproduce it?
  See docs
• Anything we should know about your environment.
  I'm not sure why NewVirtualMachinesClient was removed and how we can get that information in the new version. The REST API still supports it https://learn.microsoft.com/en-us/azure/templates/microsoft.connectedvmwarevsphere/2022-01-10-preview/virtualmachines?pivots=deployment-language-arm-template

[Alancere]

Hi @erezrokah thanks for this issue! .
You can check the information of the new version on CHANGELOG. I have submitted PR to fix doc.

[erezrokah]

Thanks @erezrokah I can see it was removed, I'm just not sure what replaced it. It's still available in the REST API and the old version of the Go SDK that has it still works

[Alancere]

The sdk/resourcemanager/connectedvmware/armconnectedvmware/v1.0.0 generated is dependent on the swagger

[github-actions]

Hi @erezrokah. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

[erezrokah]

The sdk/resourcemanager/connectedvmware/armconnectedvmware/v1.0.0 generated is dependent on the swagger

Thank you for the response. Can we you advise how can someone use the Go SDK to retrieve the data from https://learn.microsoft.com/en-us/azure/templates/microsoft.connectedvmwarevsphere/2022-01-10-preview/virtualmachines?pivots=deployment-language-arm-template?

What should we use instead of NewVirtualMachinesClient?

[Alancere]

The sdk/resourcemanager/connectedvmware/armconnectedvmware/v1.0.0 generated is dependent on the swagger

Thank you for the response. Can we you advise how can someone use the Go SDK to retrieve the data from https://learn.microsoft.com/en-us/azure/templates/microsoft.connectedvmwarevsphere/2022-01-10-preview/virtualmachines?pivots=deployment-language-arm-template?

What should we use instead of NewVirtualMachinesClient?

Service Team Answer: the VIrtualMachine resource has been removed from the latest swagger due to resource modelling change. VirtualMachineInstance is the newly added resource type for this: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/connectedvmware/resource-manager/Microsoft.ConnectedVMwarevSphere/stable/2023-10-01/connectedvmware.json#L2623

You could try NewVirtualMachineInstancesClient

[erezrokah]

You could try NewVirtualMachineInstancesClient

I'm trying to use this one but looking at the example looks like I need to pass a VM resource ID:

azure-sdk-for-go/sdk/resourcemanager/connectedvmware/armconnectedvmware/virtualmachineinstances_client_example_test.go

Line 240 in 2621632

pager := clientFactory.NewVirtualMachineInstancesClient().NewListPager("subscriptions/fd3c3665-1729-4b7b-9a38-238e83b0f98b/resourceGroups/testrg/providers/Microsoft.HybridCompute/machines/DemoVM", nil)

How can I list the VMs and get the IDs to list the instances?

[Alancere]

You could try NewVirtualMachineInstancesClient

I'm trying to use this one but looking at the example looks like I need to pass a VM resource ID:

azure-sdk-for-go/sdk/resourcemanager/connectedvmware/armconnectedvmware/virtualmachineinstances_client_example_test.go

Line 240 in 2621632

pager := clientFactory.NewVirtualMachineInstancesClient().NewListPager("subscriptions/fd3c3665-1729-4b7b-9a38-238e83b0f98b/resourceGroups/testrg/providers/Microsoft.HybridCompute/machines/DemoVM", nil)

How can I list the VMs and get the IDs to list the instances?

You could use "subscriptions/fd3c3665-1729-4b7b-9a38-238e83b0f98b/resourceGroups/testrg/providers/Microsoft.HybridCompute/machines/DemoVM" replace "subscriptions/fd3c3665-1729-4b7b-9a38-238e83b0f98b/resourceGroups/testrg" try

[erezrokah]

Passing scope := "subscriptions/****/resourceGroups/****/providers/Microsoft.HybridCompute/machines" I get

GET https://management.azure.com/subscriptions/****/resourceGroups/****/providers/Microsoft.HybridCompute/machines/providers/Microsoft.ConnectedVMwarevSphere/virtualMachineInstances

The Resource 'Microsoft.HybridCompute/machines/providers' under resource group '****' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix

Passing scope := "subscriptions/****/resourceGroups/****" I get

GET https://management.azure.com/subscriptions/****/resourceGroups/****/providers/Microsoft.ConnectedVMwarevSphere/virtualMachineInstances

Resource type 'virtualmachineinstances' of provider namespace 'Microsoft.ConnectedVMwarevSphere' was not found in global location for api version '2023-10-01'

Which one should I use and are the errors expected?

[github-actions]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @akashkeshari.

[erezrokah]

Hi 👋 When are we expected to receive an update on the issue?

[Alancere]

I found that virtualmachineinstances already exist on azure portal. Please try again.

[github-actions]

Hi @erezrokah. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

[erezrokah]

I found that virtualmachineinstances already exist on azure portal. Please try again.

Hi @Alancere which scope from #22158 (comment) is expected to work?