Update sorting algorithm used in storage shared-key signing #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microzchang
approved these changes
Apr 18, 2024
14 tasks
microzchang
added a commit
to microzchang/azure-sdk-for-cpp
that referenced
this pull request
Apr 23, 2024
…zure#5547)" This reverts commit b6e04fd.
Jinming-Hu
pushed a commit
that referenced
this pull request
Apr 23, 2024
microzchang
added a commit
that referenced
this pull request
Apr 23, 2024
* Sync eng/common directory with azure-sdk-tools for PR 8110 (#5540) * Show review link in logs and set DevOps project name based on the pipeline run * Handle the failures when package work item is unassigned (#5551) Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com> * Revert win2022 image back to latest and add msvc version mitigation (#5539) * Revert win2022 image back to latest * Workaround fix for MSVC SxS issue * Fix Policheck step indention (#5553) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Sync .github/workflows directory with azure-sdk-tools for PR 8131 (#5555) * Update to azure/login@v2 * Remove the unnecessary setting of enable-AzPSSession. We don't need it. --------- Co-authored-by: James Suplizio <jasupliz@microsoft.com> * Update sorting algorithm used in storage shared-key signing (#5547) * Remove Windows upgrade of cmake (windows image now uses working version of cmake) (#5558) * Revert "Update sorting algorithm used in storage shared-key signing (#5547)" (#5560) This reverts commit b6e04fd. --------- Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: JinmingHu <jinmhu@microsoft.com>
Jinming-Hu
added a commit
to Jinming-Hu/azure-sdk-for-cpp
that referenced
this pull request
Apr 23, 2024
…zure#5547)" (Azure#5560) This reverts commit 886f01d.
14 tasks
microzchang
pushed a commit
that referenced
this pull request
Apr 23, 2024
microzchang
added a commit
to microzchang/azure-sdk-for-cpp
that referenced
this pull request
May 27, 2024
* Sync eng/common directory with azure-sdk-tools for PR 8110 (Azure#5540) * Show review link in logs and set DevOps project name based on the pipeline run * Handle the failures when package work item is unassigned (Azure#5551) Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com> * Revert win2022 image back to latest and add msvc version mitigation (Azure#5539) * Revert win2022 image back to latest * Workaround fix for MSVC SxS issue * Fix Policheck step indention (Azure#5553) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Sync .github/workflows directory with azure-sdk-tools for PR 8131 (Azure#5555) * Update to azure/login@v2 * Remove the unnecessary setting of enable-AzPSSession. We don't need it. --------- Co-authored-by: James Suplizio <jasupliz@microsoft.com> * Update sorting algorithm used in storage shared-key signing (Azure#5547) * Remove Windows upgrade of cmake (windows image now uses working version of cmake) (Azure#5558) * Revert "Update sorting algorithm used in storage shared-key signing (Azure#5547)" (Azure#5560) This reverts commit b6e04fd. --------- Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: JinmingHu <jinmhu@microsoft.com>
microzchang
added a commit
that referenced
this pull request
May 28, 2024
* update to stable (#5541) * Storage/ Merge main to unblock pipeline failure (#5561) * Sync eng/common directory with azure-sdk-tools for PR 8110 (#5540) * Show review link in logs and set DevOps project name based on the pipeline run * Handle the failures when package work item is unassigned (#5551) Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com> * Revert win2022 image back to latest and add msvc version mitigation (#5539) * Revert win2022 image back to latest * Workaround fix for MSVC SxS issue * Fix Policheck step indention (#5553) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Sync .github/workflows directory with azure-sdk-tools for PR 8131 (#5555) * Update to azure/login@v2 * Remove the unnecessary setting of enable-AzPSSession. We don't need it. --------- Co-authored-by: James Suplizio <jasupliz@microsoft.com> * Update sorting algorithm used in storage shared-key signing (#5547) * Remove Windows upgrade of cmake (windows image now uses working version of cmake) (#5558) * Revert "Update sorting algorithm used in storage shared-key signing (#5547)" (#5560) This reverts commit b6e04fd. --------- Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: JinmingHu <jinmhu@microsoft.com> * Storage/STG94 Snapshot management support via REST for NFS shares (#5543) * add nfs support (#5267) * add test recordinhg * Storage/STG94 GetAccountInfo() for container and blob (#5550) * add getaccountinfo * update record * Storage/STG94 Add Queues bearer challenge test case (#5556) * Add test for queue bearer challenge * update test case * update var name * update test case * fix clang format * Update sorting algorithm used in storage shared-key signing (#5611) * Storage/Stg94 Support for authorization ExtendedErrorDetail (#5633) * Support for authorization ExtendedErrorDetail * fix clang format * fix build error * make tests live only * Update change log * remove additional changes * update changelog * update error detail liveonly * Update live test --------- Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: JinmingHu <jinmhu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.