Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix internal trouter behavior for stop #884

Merged
merged 2 commits into from
Sep 16, 2021
Merged

fix internal trouter behavior for stop #884

merged 2 commits into from
Sep 16, 2021

Conversation

CHILIU-MSFT
Copy link
Member

close() instead of stop() to prevent app crash if an invalid skypetoken is passed in at the beginning

@CHILIU-MSFT CHILIU-MSFT requested review from JianpingChen and a team as code owners September 16, 2021 04:51
@ghost ghost added the Communication label Sep 16, 2021
@juancamilor juancamilor merged commit dd712c9 into Azure:hotfix/azure-communication-chat_1.0.1 Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancamilor juancamilor juancamilor approved these changes

@LuChen-Microsoft LuChen-Microsoft Awaiting requested review from LuChen-Microsoft

@JianpingChen JianpingChen Awaiting requested review from JianpingChen JianpingChen is a code owner

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CHILIU-MSFT @juancamilor