Sync eng/common directory with azure-sdk-tools for PR 995 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add double support to JSON builder - az_json_builder_append_double_number * Add az_json_token_get methods for different integer sizes and doubles. * Make sure strings with negative values aren't allowed for unsigned parsing. * Fix tests for parsing infinity, and use _is_double_equal helper. * A really small number resulting in 0 is also compiler specific. * Address feedback, add comments for overflow/underflow cases. * Address PR feedback.
…zure#907) * Fix TODO to use int32 when parsing JSON in paho iot hub twin sample. * Address feedback, remove temporary local.
* adds (void) * fixes hex printout * checks punctuation
.\ required to execute vcpkg.exe in Powershell (default for Windows Terminal).
In certain cases, VCPKG packages need to be upgraded. Adding documentation on how to do this.
* Update return types to void and use exit() on error * Refactor main() * Add logging macros * Remove excess commenting
* Adding WSS APIs, fixing Y2k38 issue. Adding WebSocket sample option for SAS. Moving .vscode into vscode_config to avoid interfering with VSCode personalization and overwriting command-line cmake configuration. * Fixing Telemetry sample. * Fixing use-after-free bug in provisioning sample. * Reverting .vscode change for now. * Reverting readme.md re .vscode
* Throw cmake error when setting MOCK ON without gcc * Apply suggestions from code review Co-authored-by: Ahson Khan <ahkha@microsoft.com> Co-authored-by: Ahson Khan <ahkha@microsoft.com>
) The documentation got modified previosly by 2d589c9
remove package .txt files
* Update codeowners * Adjust codeowners
* Add caching for Vcpkg * correct syntax * correct syntax * correct syntax * add condition for vcpkg version * Only bootstrap vcpkg if the cache did not restore * add engsys versioning * clarify engsys version string * Tighten up inner loop * formatting * Caching changes and names * comma * sudo rm * sudo mkdir * chmod 777 * whoami * id * chown * what's wrong with mac * Set path for vcpkg * Revert "what's wrong with mac" This reverts commit fb7abc139dd3c1717358272ac38bbaf162a09f4d. * Revert "Tighten up inner loop" This reverts commit 564b6d8a2e02449f173023c48fd9c3800547a19a. * Add ability to skip vcpkg cache * Remove engsys version key from cache * Add vcpkg information to README.md * Add vcpkg language to other places referenced in README.md * Update antecedent * Review feedback: use vcpkg tag, remove redundant inaccurate comment * Apply suggestions from code review Co-authored-by: Ahson Khan <ahkha@microsoft.com> * Wrap key in quotes to prevent it being read as a file Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Create DPS SAS sample * Create src/ and inc/ under samples/iot. Move sas utility files in * Update cmake files * Update cert generation scripts
* Update DPS generate certificate scripts * Overhaul DPS sample readme
Update logging for TRUST PEM. Align code with macros ordering.
* SAS use auto generate primary key * TRUST PEM info for all samples for Windows * Remove TRUST PEM info from cert generate scrips since also required for SAS
* synchronous * samples can accept up to 5 messages
* updates on samples verbiage * Update sdk/samples/iot/docs/how_to_iot_hub_esp8266_nodemcu.md Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com> Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
* warning: header guard does not follow preferred style [llvm-header-guard] * warning: use of a signed integer operand with a binary bitwise operator [hicpp-signed-bitwise] - headers * warning: pragma diagnostic pop could not pop, no matching push [clang-diagnostic-unknown-pragmas] - disable * warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses] * warning: Call to function 'memset' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memset_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] - disable * warning: use of a signed integer operand with a binary bitwise operator [hicpp-signed-bitwise] - header - 2 * warning: 10 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers] - header * Fix warning C4312: 'type cast': conversion from 'unsigned int' to 'uint8_t *' of greater size. * warning: do not use 'else' after 'return'/'break' [readability-else-after-return] * warning: statement should be inside braces [google-readability-braces-around-statements] * warning: Value stored to 'url_remainder' is never read [clang-analyzer-deadcode.DeadStores] * warning: 0x20 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers] [readability-magic-numbers] * warning: use of a signed integer operand with a binary bitwise operator [hicpp-signed-bitwise] - source * warning: Call to function 'sscanf' is insecure as it does not provide bounding of the memory buffer or security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'sscanf_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] - disabled, same with memmove. * warning: potential uncovered code path; add a default label [hicpp-multiway-paths-covered] * warning: redundant cast to the same type [google-readability-casting] * warning: #includes are not sorted properly [llvm-include-order] * warning: statement should be inside braces [google-readability-braces-around-statements] - az_curl.c - 2 * [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] memcpy and memset - disable * warning: variable 'result' is not initialized [cppcoreguidelines-init-variables] * warning: either cast from 'long' to 'int64_t' (aka 'long long') is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast] * warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix] * warning: 0x7FF0000000000000ULL is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers] * [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] - disble - memcpy - private header * warning: use of a signed integer operand with a binary bitwise operator [hicpp-signed-bitwise] - private header. * Auto-format files modified in this PR. * Cast error az_result values back down to int32_t. * Explicitly cast unsigned int result from bit-shift back to int32_t, in az_retry_internal.h. * Address PR feedback. * Add back the cast.
… files in the repo. (Azure#1243) Ran the following at the root of the repo: ```bash find . \( -iname '*.h' -o -iname '*.c' \) -exec clang-format -i {} \; ```
Since this leg also performance test coverage checks and other linter/formatting validation, naming it as such makes it easier to find.
… properly formatted according to .clang-format (Azure#1278) If this CI validation fails, please run clang-format to fix the issue. > find . \( -iname '*.h' -o -iname '*.c' \) -exec clang-format -i {} \;
@antkmsft - this change slipped through between the clang format validation check PR and the recent PAL update. Azure/azure-sdk-for-c#1256 It is blocking CI for other PRs atm.
* Adding cmake module for customer to consume SDK with SDK as dependency
…Azure#1304) IAR warning for int assignment to an enum.
…zure#1312) warning on { 0 } init.
…ders without introducing new typedefs (Azure#1297) * Turn az_resut enum values to macros. * Move the IoT specific macros. * Add new line. * Make sure all az_result values have the same type, signed int. * Use anonymous enums instead of define macros. * Add names to enums. * Fixup names and update changelog. * Add _core suffix to az_result and log. * Update doc comment to include references to each header. * Address PR feedback - use alias'd name for cast. * Revert unrelated, accidental comment formatting change.
* update for samples running and iot samples
decd87e to
27f364c
Compare
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-android
that referenced
this pull request
Sep 18, 2020
* Add samples into Sample folders Add ability to build the SDK without building samples -By default samples are built -To disable samples set AZ_SDK_C_NO_SAMPLES=1
azure-sdk
pushed a commit
that referenced
this pull request
Sep 26, 2020
* Add/edit comment on Ctrl+Enter Fixes #352 * Simplify form submission Also handles both keyCode 10 and 13, since some versions of Chrome on some platforms send the wrong keyCode: https://bugs.chromium.org/p/chromium/issues/detail?id=79407 * Resolve PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#995
See eng/common workflow