Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate permission from manifest #1238

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Remove duplicate permission from manifest #1238

merged 1 commit into from
Jan 20, 2023

Conversation

kostasdrakonakis
Copy link
Contributor

No description provided.

@ghost ghost added Communication customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Nov 14, 2022
@ghost
Copy link

ghost commented Nov 14, 2022

Thank you for your contribution @kostasdrakonakis! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Nov 14, 2022
@ghost
Copy link

ghost commented Nov 14, 2022

Thank you for your contribution @kostasdrakonakis! We will review the pull request and get back to you soon.

@kostasdrakonakis
Copy link
Contributor Author

kostasdrakonakis commented Nov 14, 2022 •
edited
Loading

Fixes #1206

vcolin7
vcolin7 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@vcolin7 vcolin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Any thoughts @jiminwen-msft?

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Jan 20, 2023
@ghost
Copy link

ghost commented Jan 20, 2023

Hi @kostasdrakonakis. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@kostasdrakonakis
Copy link
Contributor Author

@vcolin7 @jiminwen-msft are we going to merge this one?

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label Jan 20, 2023
@vcolin7
Copy link
Member

vcolin7 commented Jan 20, 2023

I think it's safe to merge this.

@vcolin7 vcolin7 merged commit 7247985 into Azure:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcolin7 vcolin7 vcolin7 approved these changes

@JianpingChen JianpingChen Awaiting requested review from JianpingChen

Assignees
No one assigned
Labels
Communication Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostasdrakonakis @vcolin7