Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phone number serialization #1207

Conversation

maximrytych-ms
Copy link
Member

Fixed the logic of PhoneNumberIdentifier to always maintain the original phone number string whether it included the leading + sign or not.

Copy link
Member

@vcolin7 vcolin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment about the release date in the CHANGELOG.

@maximrytych-ms
Copy link
Member Author

/azp run android - azure-communication-common - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Copy link
Member

@AikoBB AikoBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add the bugfix info in the changelog:

### Bugs Fixed
- Fixed the logic of `PhoneNumberIdentifier` to always maintain the original phone number string whether it included the leading + sign or not.

@maximrytych-ms maximrytych-ms requested a review from AikoBB October 27, 2022 09:42
@AikoBB AikoBB merged commit c68f243 into Azure:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants