Jimin/dev8 #1179
Merged
Jimin/dev8 #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jiminwen-msft
commented
Aug 23, 2022
- Modify the error message thrown for users not making push notification configurations.
- Deprecate existing startPushNotification method with error handler. And create new methods without error handlers. The error handling logic will get executed in the RegistrationRenewalWorker class
vcolin7
reviewed
Aug 23, 2022
...e-communication-chat/src/main/java/com/azure/android/communication/chat/ChatAsyncClient.java
Outdated
Show resolved
Hide resolved
...zure/android/communication/chat/implementation/notifications/fcm/PushNotificationClient.java
Outdated
Show resolved
Hide resolved
| @@ -225,11 +225,26 @@ public void stopRealtimeNotifications() { | |||
| * @param deviceRegistrationToken Device registration token obtained from the FCM SDK. | |||
| * @param errorHandler error handler callback for registration failures | |||
| * @throws RuntimeException if push notifications failed to start. | |||
| * @deprecated The function will be replaced by startPushNotifications(String deviceRegistrationToken) | |||
There was a problem hiding this comment.
Same comment about using JavaDoc linking.
...e/android/communication/chat/implementation/notifications/fcm/RegistrationRenewalWorker.java
Outdated
Show resolved
Hide resolved
...e/android/communication/chat/implementation/notifications/fcm/RegistrationRenewalWorker.java
Outdated
Show resolved
Hide resolved
…zure/android/communication/chat/implementation/notifications/fcm/RegistrationRenewalWorker.java Co-authored-by: vcolin7 <vicolina@microsoft.com>
…zure/android/communication/chat/implementation/notifications/fcm/RegistrationRenewalWorker.java Co-authored-by: vcolin7 <vicolina@microsoft.com>
vcolin7
requested changes
Aug 25, 2022
vcolin7
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.