Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire use of generic blob publish #1057

Closed
wants to merge 7 commits into from

Conversation

chidozieononiwu
Copy link
Member

  • Retire use of the public-blob.yml from build tools repo.
  • Add template package for android.

@ghost ghost added the EngSys This issue is impacting the engineering system. label Mar 16, 2022
@@ -0,0 +1,42 @@
resources:
repositories:
- repository: azure-sdk-build-tools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still necessary?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's still used for Publishing and GPG signing

@chidozieononiwu chidozieononiwu force-pushed the RetireUseOfGenericBlobPublish branch 4 times, most recently from 58bedf0 to 1c7f8c6 Compare March 22, 2022 23:10
@chidozieononiwu chidozieononiwu added the Central-EngSys This issue is owned by the Engineering System team. label Mar 24, 2022
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run android - [service] - ci

@chidozieononiwu chidozieononiwu force-pushed the RetireUseOfGenericBlobPublish branch 3 times, most recently from c94c7f7 to 047b614 Compare April 25, 2022 23:37
@chidozieononiwu chidozieononiwu force-pushed the RetireUseOfGenericBlobPublish branch from 51ff2d3 to b48c9ac Compare April 26, 2022 17:14
@chidozieononiwu chidozieononiwu force-pushed the RetireUseOfGenericBlobPublish branch from b48c9ac to 789dc35 Compare April 26, 2022 20:29
- sdk/template/

extends:
template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
template: /eng/pipelines/templates/stages/archetype-sdk-client.yml

@@ -84,14 +101,12 @@ stages:
dependsOn: TagRepository

pool:
vmImage: vs2017-win2016
vmImage: windows-2019
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the machine pool here as well.

@azure-sdk azure-sdk closed this May 18, 2022
@azure-sdk azure-sdk deleted the RetireUseOfGenericBlobPublish branch May 18, 2022 16:24
@chidozieononiwu chidozieononiwu restored the RetireUseOfGenericBlobPublish branch May 18, 2022 19:13
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Sep 2, 2022
@ghost
Copy link

ghost commented Sep 2, 2022

Hi @chidozieononiwu. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@chidozieononiwu
Copy link
Member Author

Closing this for now

@ghost ghost closed this Sep 13, 2022
@ghost
Copy link

ghost commented Sep 13, 2022

Hi @chidozieononiwu. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@weshaggard
Copy link
Member

@chidozieononiwu is there a tracking issue for this work? If so could you please assign it to @JimSuplizio so that we can try and clean-up the android release pipelines.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants