-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retire use of generic blob publish #1057
Conversation
chidozieononiwu
commented
Mar 16, 2022
- Retire use of the public-blob.yml from build tools repo.
- Add template package for android.
sdk/template/ci.yml
Outdated
@@ -0,0 +1,42 @@ | |||
resources: | |||
repositories: | |||
- repository: azure-sdk-build-tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hopefully not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's still used for Publishing and GPG signing
58bedf0
to
1c7f8c6
Compare
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
c94c7f7
to
047b614
Compare
51ff2d3
to
b48c9ac
Compare
b48c9ac
to
789dc35
Compare
- sdk/template/ | ||
|
||
extends: | ||
template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml | |
template: /eng/pipelines/templates/stages/archetype-sdk-client.yml |
@@ -84,14 +101,12 @@ stages: | |||
dependsOn: TagRepository | |||
|
|||
pool: | |||
vmImage: vs2017-win2016 | |||
vmImage: windows-2019 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the machine pool here as well.
Hi @chidozieononiwu. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Closing this for now |
Hi @chidozieononiwu. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
@chidozieononiwu is there a tracking issue for this work? If so could you please assign it to @JimSuplizio so that we can try and clean-up the android release pipelines. |