-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Swagger spec and samples for GA #8727
Updating Swagger spec and samples for GA #8727
Conversation
Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives.
…Prop Added dataStringComparisonBehavior parameter to reference data put/update spec
…onKeyProperty Adding partitionKeyProperty to EnvironmentCreate and EnvironmentGet request.
…lingAsString changing modelAsString for partitionKeyPRoperties
…heritance from TrackedResource.
Introduce longterm environment to TSI resource hierarchy
…ype. Updated timeseriesinsights.json
Azure Pipelines successfully started running 1 pipeline(s). |
Can one of the admins verify this patch? |
azure-sdk-for-go
|
azure-sdk-for-net
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-cli-extensions
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
azure-sdk-for-python
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -197,11 +197,11 @@ | |||
"$ref": "#/parameters/EnvironmentNameParameter" | |||
}, | |||
{ | |||
"name": "standardEnvironmentUpdateParameters", | |||
"name": "longTermEnvironmentUpdateParameters", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this fixing a Swagger bug? Otherwise it will be a breaking change
"pattern": "^[-\\w\\._\\(\\)]+$", | ||
"minLength": 1, | ||
"maxLength": 90, | ||
"description": "Name of the environment" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will be great for user to add constraint in description also.
"$ref": "#/definitions/EnvironmentResource" | ||
} | ||
}, | ||
"404": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normally no error response in Swagger. COuld you pls share some context of adding 404? thanks.
"pattern": "^[A-Za-z0-9]", | ||
"minLength": 3, | ||
"maxLength": 63, | ||
"description": "Name of the reference data set." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add constraint in description for better user experience.
"kind": { | ||
"type": "string", | ||
"description": "The kind of the environment.", | ||
"enum": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modelAsString?
"maxCount": { | ||
"format": "int32", | ||
"type": "integer", | ||
"description": "A value that represents the maximum number of properties used allowed by the environment for S1/S2 SKU and maximum number of properties allowed by Warm Store for PAYG SKU.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add constraint in description
will involve ARM review when PR ready for reviewing. |
Azure Pipelines successfully started running 1 pipeline(s). |
…imeSeriesInsights/azure-rest-api-specs into user/riserrad/tsi-2020-ga-spec
Azure Pipelines successfully started running 1 pipeline(s). |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.
Summary of changes
2020-05-15
$expand
parameter to justexpand