Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added classification reason to incident #8661

Merged
merged 14 commits into from
Mar 27, 2020
Merged

Added classification reason to incident #8661

merged 14 commits into from
Mar 27, 2020

Conversation

dosiso
Copy link
Contributor

@dosiso dosiso commented Mar 10, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@qianwens
Copy link
Member

@dosiso could you please invite reviewers from your team and add WaitForARMFeedback label since this PR adds new properties?

@dosiso
Copy link
Contributor Author

dosiso commented Mar 13, 2020

@qianwens actually I'm unable to add reviewers. Would you help me with this? Regarding the label, it shouldn't be added in my tier but in a higher one (every PR we upload gets reviewed and approved by team and then the label is added, out of our team).

@qianwens
Copy link
Member

@dosiso , please give me the reviewer's GitHub name so that I can add them.

@dosiso
Copy link
Contributor Author

dosiso commented Mar 16, 2020

@ityankel @dosegal

@qianwens qianwens requested review from ityankel and dosegal March 16, 2020 10:45
@dosegal
Copy link
Contributor

dosegal commented Mar 16, 2020

@dosiso please add "classificationReason" to the examples

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from cbfe419 with merge commit 3abe2ea. SDK Automation 13.0.17.20200326.3
  • ⚠️preview/securityinsight/mgmt/2017-08-01-preview [Logs]  
      No file is changed.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 16, 2020 •
    edited
    Loading

    azure-cli-extensions - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 16, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from cbfe419 with merge commit 3abe2ea. SDK Automation 13.0.17.20200326.3 
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 16, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 16, 2020 •
    edited
    Loading

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from cbfe419 with merge commit 3abe2ea. SDK Automation 13.0.17.20200326.3
    • ️✔️Microsoft.Azure.Management.SecurityInsights [Logs]  [Release SDK Changes]
        No Artifact Generated.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Mar 16, 2020 •
      edited
      Loading

      azure-sdk-for-python - Release

      ⚠️ warning [Logs] [Expand Details]
      • ⚠️ Generate from cbfe419 with merge commit 3abe2ea. SDK Automation 13.0.17.20200326.3 
        Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_security_insights.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_security_insights_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_actions_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_alert_rules_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_data_connectors_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/version.py

      @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 16, 2020
      Closed
      @dosiso
      Copy link
      Contributor Author

      dosiso commented Mar 25, 2020

      @qianwens any updates?

      @qianwens
      Copy link
      Member

      @akning-ms could you please help force merge this PR as the breaking change is in preview api.

      @akning-ms akning-ms merged commit 3abe2ea into Azure:master Mar 27, 2020
      00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
      @dosiso @00Kai0
      Added classification reason to incident (Azure#8661)
      629800f 
      * Added case tactics

* Added incident tactics

* Removing redundant comma from incident additional data

* Changed tabs to spaces to better match format in file

* Rename tactics field (alertTactics=>tactics)

* Rename unknown classification to undetermined classification

* Undo last commmit

* Added classification reason to incident

* Examples updated
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers

      @ityankel ityankel ityankel approved these changes

      @dosegal dosegal Awaiting requested review from dosegal

      Assignees

      @qianwens qianwens

      Labels
      None yet
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      6 participants
      @dosiso @azuresdkci @qianwens @dosegal @ityankel @akning-ms