-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import to the JSON Web Key Operations #8175
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
3 similar comments
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@heaths could you take a look at this and see how it fits into your swagger refactoring? |
I have a PR started in the private fork for preview-7.1 we should probably rebase this on. I can clean it up for public release, but is otherwise a split of services we wanted for maintainability. |
I've also already included this in the aforementioned PR. |
@heaths Does this PR needs to be abandoned if you are bringing this change with your PR ? |
The timeline for my changes is not quite solidified. For now, I recommend changing your branch to target the new preview-7.1 branch and files (i.e. rebase, but also move the changes to preview/7.1/keyvault.json) and we can get it approved and merged. I'll just have to do a "manual rebase" later when I pull my split-files change in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if the swagger review board allows modifying a shipped version, 7.0 already shipped. This is the wrong file. You need to modify stable/7.0/keyvault.json. /cc @adrianhall @johanste
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.