Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import to the JSON Web Key Operations #8175

Closed
wants to merge 2 commits into from

Conversation

vakkinep
Copy link
Contributor

@vakkinep vakkinep commented Jan 17, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

3 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vakkinep vakkinep requested a review from jkapil January 17, 2020 01:16
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 17, 2020

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 17, 2020

azure-sdk-for-net

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 17, 2020

azure-sdk-for-python

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 17, 2020

azure-sdk-for-js

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 17, 2020

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@amitbapat amitbapat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@schaabs
Copy link
Member

schaabs commented Jan 21, 2020

@heaths could you take a look at this and see how it fits into your swagger refactoring?

@heaths
Copy link
Member

heaths commented Jan 21, 2020

I have a PR started in the private fork for preview-7.1 we should probably rebase this on. I can clean it up for public release, but is otherwise a split of services we wanted for maintainability.

@heaths
Copy link
Member

heaths commented Jan 21, 2020

I've also already included this in the aforementioned PR.

@jkapil
Copy link
Member

jkapil commented Jan 23, 2020

I've also already included this in the aforementioned PR.

@heaths Does this PR needs to be abandoned if you are bringing this change with your PR ?

@heaths
Copy link
Member

heaths commented Jan 23, 2020

The timeline for my changes is not quite solidified. For now, I recommend changing your branch to target the new preview-7.1 branch and files (i.e. rebase, but also move the changes to preview/7.1/keyvault.json) and we can get it approved and merged. I'll just have to do a "manual rebase" later when I pull my split-files change in.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the swagger review board allows modifying a shipped version, 7.0 already shipped. This is the wrong file. You need to modify stable/7.0/keyvault.json. /cc @adrianhall @johanste

@heaths heaths closed this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants