Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sftp sink #7876

Merged
merged 1 commit into from
Dec 10, 2019
Merged

support sftp sink #7876

merged 1 commit into from
Dec 10, 2019

Conversation

hbzhxying
Copy link
Contributor

@hbzhxying hbzhxying commented Dec 3, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Dec 3, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8442

@AutorestCI
Copy link

AutorestCI commented Dec 3, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6468

@akning-ms akning-ms added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 4, 2019
@hbzhxying
Copy link
Contributor Author

@ravbhatnagar , could you help approve this PR? I am from Azure data factory team. We once discussed this , and we agreed not to block this kind of changes for now till ARM check with the Azure Architecture team and get a different decision. This is indeed a by-design in ADF at moment, not a breaking change.

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 4, 2019
@akning-ms
Copy link
Contributor

As hbzhxying requested, Don't merge until further inform

@akning-ms akning-ms merged commit d5b0b19 into Azure:master Dec 10, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 10, 2019

azure-sdk-for-java - Release

Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 10, 2019

azure-sdk-for-python - Release

Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 10, 2019

azure-sdk-for-net - Release

Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 10, 2019

azure-sdk-for-js - Release

Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 10, 2019

azure-sdk-for-go - Release

Pending...

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants