-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new version of API with object store, sku selection and arm lite user #7808
Conversation
it is approved by ARM team in private repo https://github.com/Azure/azure-rest-api-specs-pr/pull/967 |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goA PR has been created for you: |
Can one of the admins verify this patch? |
...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2019-08-01/databoxedge.json
Outdated
Show resolved
Hide resolved
...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2019-08-01/databoxedge.json
Show resolved
Hide resolved
...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2019-08-01/databoxedge.json
Show resolved
Hide resolved
@yungezz, @ryansbenson : Can you please complete the review and help to merge it. The same PR is reviewed and approved by ARM team in private repo https://github.com/Azure/azure-rest-api-specs-pr/pull/967 |
...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2019-08-01/databoxedge.json
Outdated
Show resolved
Hide resolved
...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2019-08-01/databoxedge.json
Show resolved
Hide resolved
} | ||
], | ||
"apiVersions": [ | ||
"2019-09-01" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2019-08-01?
hi @anponnet pls fix SpellCheck error from CI. thanks. |
Hi @yungezz I have fixed all comments except on spellcheck. The flagged contract was already approved (And it is a valid word) and it is in production, which we cannot change. Can you please add an exception and merge it? |
.../databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2019-08-01/examples/ListSkus.json
Outdated
Show resolved
Hide resolved
here's guide on how to fix SpellCheck error: https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#spell-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yungezz I have fixed all comments except on spellcheck. The flagged contract was already approved (And it is a valid word) and it is in production, which we cannot change. Can you please add an exception and merge it?
here's guide on how to fix SpellCheck error: https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#spell-check
@yungezz , Thank you, I have fixed the errors and 17 checks are successful (One is marked as ignore-testonly)
...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2019-08-01/databoxedge.json
Show resolved
Hide resolved
...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2019-08-01/databoxedge.json
Show resolved
Hide resolved
...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2019-08-01/databoxedge.json
Outdated
Show resolved
Hide resolved
...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2019-08-01/databoxedge.json
Show resolved
Hide resolved
HI @ryansbenson could you pls have a look again? The PR is reviewed in private repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/967/files |
@yungezz , can you hold the merge till we confirm |
sure. Pls add label "DoNotMerge" and "[Do Not Merge]" in title to PR not ready for merging in future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off for ARM
Azure Pipelines successfully started running 1 pipeline(s). |
@yungezz I have made a one line change to API, it is a tag/operationId change... Can you see it once |
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yungezz I have made a one line change to API, it is a tag/operationId change... Can you see it once
hi @anponnet operationId change is breaking change, it will break SDKs generated from the swagger file. Does the changed operationId align with service behavior on production now?
Hi @yungezz It is a new API and there is no SDK for this, so no breaking. I dont think there is any hard dependency between service code and operationId, it just maps sdk method to API in swagger, and makes http request with the url, is it right understanding?
.../databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2019-08-01/examples/ListSkus.json
Outdated
Show resolved
Hide resolved
@yungezz , Our service deployment is complete, can you please merge this PR? |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.