Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new version of API with object store, sku selection and arm lite user #7808

Merged
merged 16 commits into from
Dec 9, 2019
Merged

Add new version of API with object store, sku selection and arm lite user #7808

merged 16 commits into from
Dec 9, 2019

Conversation

anponnet
Copy link
Contributor

@anponnet anponnet commented Nov 20, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@anponnet
Copy link
Contributor Author

it is approved by ARM team in private repo https://github.com/Azure/azure-rest-api-specs-pr/pull/967

@AutorestCI
Copy link

AutorestCI commented Nov 20, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8736

@AutorestCI
Copy link

AutorestCI commented Nov 20, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6394

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 20, 2019
@ryansbenson ryansbenson added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 20, 2019
@yungezz yungezz removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 21, 2019
@anponnet
Copy link
Contributor Author

@yungezz, @ryansbenson : Can you please complete the review and help to merge it. The same PR is reviewed and approved by ARM team in private repo https://github.com/Azure/azure-rest-api-specs-pr/pull/967

}
],
"apiVersions": [
"2019-09-01"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2019-08-01?

@yungezz
Copy link
Member

yungezz commented Nov 26, 2019

hi @anponnet pls fix SpellCheck error from CI. thanks.

@anponnet
Copy link
Contributor Author

Hi @yungezz I have fixed all comments except on spellcheck. The flagged contract was already approved (And it is a valid word) and it is in production, which we cannot change. Can you please add an exception and merge it?

@yungezz
Copy link
Member

yungezz commented Nov 26, 2019

Hi @yungezz I have fixed all comments except on spellcheck. The flagged contract was already approved (And it is a valid word) and it is in production, which we cannot change. Can you please add an exception and merge it?

here's guide on how to fix SpellCheck error: https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#spell-check

Copy link
Contributor Author

@anponnet anponnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yungezz I have fixed all comments except on spellcheck. The flagged contract was already approved (And it is a valid word) and it is in production, which we cannot change. Can you please add an exception and merge it?

here's guide on how to fix SpellCheck error: https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#spell-check

@yungezz , Thank you, I have fixed the errors and 17 checks are successful (One is marked as ignore-testonly)

@yungezz
Copy link
Member

yungezz commented Nov 26, 2019

HI @ryansbenson could you pls have a look again? The PR is reviewed in private repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/967/files

@anponnet
Copy link
Contributor Author

@yungezz , can you hold the merge till we confirm

@yungezz yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Nov 27, 2019
@yungezz
Copy link
Member

yungezz commented Nov 27, 2019

@yungezz , can you hold the merge till we confirm

sure. Pls add label "DoNotMerge" and "[Do Not Merge]" in title to PR not ready for merging in future.

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off for ARM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Dec 3, 2019
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anponnet
Copy link
Contributor Author

anponnet commented Dec 4, 2019

@yungezz I have made a one line change to API, it is a tag/operationId change... Can you see it once

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b288943 with merge commit 5b0834b. SDK Automation 13.0.17
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/1096: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"121","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 09 Dec 2019 04:33:14 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C8:1BB5:34290BD:72AAB32:5DEDCE8A","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4967","x-ratelimit-reset":"1575869580","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/databoxedge_mgmt_2019-08-01@7808","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/10.17.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
  • ⚠️databoxedge/mgmt/2019-03-01 [Logs
      No file is changed.
    • ⚠️databoxedge/mgmt/2019-07-01 [Logs
        No file is changed.
      • ️✔️databoxedge/mgmt/2019-08-01 [Logs]  [Release SDK Changes]

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Dec 4, 2019

      azure-sdk-for-java - Release

      🔄 inProgress [Logs] [Expand Details]
      • 🔄 Generate from b288943 with merge commit 5b0834b. SDK Automation 13.0.17

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Dec 4, 2019

      azure-sdk-for-js - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from b288943 with merge commit 5b0834b. SDK Automation 13.0.17
        Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-js/pull/49: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"121","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 09 Dec 2019 04:33:10 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07D0:360E:12BB870:3015099:5DEDCE86","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4975","x-ratelimit-reset":"1575869580","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-js/git/refs/heads/sdkAutomation/@azure_arm-databoxedge@7808","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/10.17.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
      • ️✔️@azure/arm-databoxedge [Logs]  [Release SDK Changes]
        [npmPack] loaded rollup.config.js with warnings
        [npmPack] (!) Unused external imports
        [npmPack] default imported from external module 'rollup' but never used
        [npmPack] 
        [npmPack] ./esm/dataBoxEdgeManagementClient.js → ./dist/arm-databoxedge.js...
        [npmPack] created ./dist/arm-databoxedge.js in 672ms

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Dec 4, 2019

      azure-sdk-for-net - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from b288943 with merge commit 5b0834b. SDK Automation 13.0.17
        Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-net/pull/156: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"121","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 09 Dec 2019 04:33:10 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07CF:315E:5B0160C:B75F2D6:5DEDCE86","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4974","x-ratelimit-reset":"1575869580","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-net/git/refs/heads/sdkAutomation/Microsoft.Azure.Management.DataBoxEdge@7808","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/10.17.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
      • ️✔️Microsoft.Azure.Management.DataBoxEdge [Logs]  [Release SDK Changes]

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Dec 4, 2019

      azure-sdk-for-python - Release

      ⚠️ warning [Logs] [Expand Details]
      • ⚠️ Generate from b288943 with merge commit 5b0834b. SDK Automation 13.0.17
        Failed to find any changed packages. Please check the changed file list.
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/__init__.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/_configuration.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/_data_box_edge_management_client.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/models/__init__.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/models/_data_box_edge_management_client_enums.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/models/_models.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/models/_models_py3.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/models/_paged_models.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/__init__.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_alerts_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_bandwidth_schedules_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_containers_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_devices_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_jobs_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_nodes_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_operations_status_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_orders_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_roles_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_shares_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_skus_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_storage_account_credentials_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_storage_accounts_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_triggers_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/operations/_users_operations.py
        /z/work/azure-sdk-for-python/sdk/databoxedge/azure-mgmt-databoxedge/azure/mgmt/databoxedge/version.py

      @yungezz
      Copy link
      Member

      yungezz commented Dec 4, 2019

      @yungezz I have made a one line change to API, it is a tag/operationId change... Can you see it once

      hi @anponnet operationId change is breaking change, it will break SDKs generated from the swagger file. Does the changed operationId align with service behavior on production now?

      Copy link
      Contributor Author

      @anponnet anponnet left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      @yungezz I have made a one line change to API, it is a tag/operationId change... Can you see it once

      hi @anponnet operationId change is breaking change, it will break SDKs generated from the swagger file. Does the changed operationId align with service behavior on production now?

      Hi @yungezz It is a new API and there is no SDK for this, so no breaking. I dont think there is any hard dependency between service code and operationId, it just maps sdk method to API in swagger, and makes http request with the url, is it right understanding?

      @anponnet
      Copy link
      Contributor Author

      anponnet commented Dec 9, 2019

      @yungezz , Our service deployment is complete, can you please merge this PR?

      @yungezz yungezz removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 9, 2019
      @yungezz yungezz merged commit 5b0834b into Azure:master Dec 9, 2019
      TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      6 participants