Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding swagger changes for GET and LIST replicationEligibilityResults API #7698

Merged

Conversation

punit-bhatt
Copy link
Contributor

@punit-bhatt punit-bhatt commented Nov 4, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Nov 4, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@punit-bhatt
Copy link
Contributor Author

punit-bhatt commented Nov 4, 2019

This extension type API has already been approved by the ARM team.
The API validates if a VM can be protected or not. Thus, the results are read only. As you can see, all the properties are readOnly.
Sharing a link to the email

@AutorestCI
Copy link

AutorestCI commented Nov 4, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@punit-bhatt
Copy link
Contributor Author

punit-bhatt commented Nov 4, 2019

LintDiff tests are failing with the following error

R2059 - UniqueResourcePaths
Multiple resource providers are not allowed in a single spec. More than one the resource paths were found: 'Microsoft.RecoveryServices, Microsoft.Compute'.

But since this is an extension routing type API, the uri will contain 2 providers.

@punit-bhatt
Copy link
Contributor Author

ModelValidation tests are failing due to older properties checked in probably before the model validation started running. The errors have nothing to do with the properties added in this PR.
We have a work item open for the same but that has been getting delayed indefinitely. Will take it up and open a PR for the same by the end of this week.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@punit-bhatt punit-bhatt changed the title Adding swagger changes for GET and LIST replicationEligibilityResults API Adding swagger changes for GET and LIST replicationEligibilityResults API [Do Not MERGE] Nov 4, 2019
@punit-bhatt
Copy link
Contributor Author

Have suppressed the UniqueResourcePaths error type. Having another spec wouldn't have worked because either of the specs will have 2 providers in it leading to the same issue.

@yungezz yungezz merged commit e3b8619 into Azure:master Nov 6, 2019
@punit-bhatt punit-bhatt changed the title Adding swagger changes for GET and LIST replicationEligibilityResults API [Do Not MERGE] Adding swagger changes for GET and LIST replicationEligibilityResults API Nov 6, 2019
@punit-bhatt punit-bhatt deleted the origin/pubhatt/replicationEligibilityResults branch November 6, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants