Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iot central minor swagger changes and description fixes #7656

Conversation

rafarhat
Copy link
Member

@rafarhat rafarhat commented Oct 29, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 29, 2019

In Testing, Please Ignore

[Logs] (Generated from 53ee5c8, Iteration 7)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@AutorestCI
Copy link

AutorestCI commented Oct 29, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@rafarhat rafarhat marked this pull request as ready for review October 29, 2019 01:04
@rafarhat rafarhat changed the title minor swagger changes and description fixes iot central minor swagger changes and description fixes Oct 29, 2019
@weidongxu-microsoft weidongxu-microsoft added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Oct 29, 2019
@weidongxu-microsoft
Copy link
Member

Pending for API board.

@rafarhat Please add code owner of the service to PR (if available) as well. Thanks.

@avneet723
Copy link

@yaohaizh This is an update for our Swagger for the same set of IoT Central APIs that we have approval from API review board. Could you please take a look and add the appropriate tag?

@yaohaizh yaohaizh added AzureAPIBoardSignedOff and removed APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. labels Oct 29, 2019
@yaohaizh
Copy link
Contributor

@avneet723 @weidongxu-microsoft updated.

@weidongxu-microsoft weidongxu-microsoft merged commit 194d8a8 into Azure:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants