Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stable version for Data Share and in place sharing support for Kusto #7641

Merged
merged 7 commits into from
Oct 29, 2019

Conversation

sarajang
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 25, 2019

@AutorestCI
Copy link

AutorestCI commented Oct 25, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6177

@sarajang sarajang changed the title Add stable version for Data Share Add stable version for Data Share and in place sharing support for Kusto Oct 25, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anthony-c-martin
Copy link
Member

This PR mostly consists of changes which have already been signed off on in azure-rest-api-specs-pr. I'm signing off on the introduction of new stable version + additional "sourceShareLocation" field.

@anthony-c-martin anthony-c-martin added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 25, 2019
@sarajang
Copy link
Member Author

@erich-wang please merge this PR when you get a chance. thanks.

Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the output-folder in readme.go.md, which will cause a CI failure in go SDK. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants