Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miss spelling property name and case sensitive #7616

Merged
merged 10 commits into from
Oct 29, 2019
Merged

Fix miss spelling property name and case sensitive #7616

merged 10 commits into from
Oct 29, 2019

Conversation

LingyunSu
Copy link
Contributor

@LingyunSu LingyunSu commented Oct 24, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Fix miss spelling property name externalDnsIPAddress
Case sensitive fix in Fabriclocation
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 24, 2019

In Testing, Please Ignore

[Logs] (Generated from 8af4bb8, Iteration 11)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@LingyunSu
Copy link
Contributor Author

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 24, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@mmyyrroonn
Copy link
Contributor

@LingyunSu Hi. Because you do such change in the preview version, it's fine. Could you revolve the conflicts first?

@bganapa
Copy link
Member

bganapa commented Oct 24, 2019

@myronfanqiu Resolved the conflicts. It is actually a bug fix that we must take. Thanks!

@mmyyrroonn
Copy link
Contributor

@LingyunSu Hello. If you make sure that you want such change, please add suppression in the readme.file to fix LintDiff. For the Spellcheck, please add these words into https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt. Please double check the change.

@mmyyrroonn
Copy link
Contributor

Such change may cause problems for SDK generation. externalDNSIPAddress01 will be external_d_n_s_i_p_address01 in some SDKs.

@mmyyrroonn
Copy link
Contributor

Can you share the context about this PR?

@bganapa
Copy link
Member

bganapa commented Oct 24, 2019

@myronfanqiu our admin RP response for this api comes with the json format externalDNSIPAddress01, so we are in need of matching that in swagger without ignoring the case.
We ship only azure powershell/.Net SD for these azure stack administrator APIs. We do not foresee any need of shipping any other SDKs for these AZURESTACK admin specific APIs. Note that these APIs don't exist in azure. It seems like the guidance is the RP response should have got externalDnsIpAddress01 instead of externalDNSIPAddress01. Is there any doc on this guidance?(I dont see it here https://github.com/Azure/azure-resource-manager-rpc) . This change is needed for our ignite release and we are out of time to make the change at the RP code. I suggest lets merge this one to fix the powershell issue and we will track an issue internally to change the RP code if needed. Hope that makes sense

@mmyyrroonn
Copy link
Contributor

@bganapa Hello. If you make sure that you want such change, please add suppression in the readme.file to fix LintDiff. For the Spellcheck, please add these words into https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt.

Fix CI so that I can merge it.

Add new custom words for Fabriclocation model
@LingyunSu
Copy link
Contributor Author

@bganapa @myronfanqiu new custom words added.

@mmyyrroonn
Copy link
Contributor

@LingyunSu please add suppression in the readme.file to fix LintDiff.

@mmyyrroonn
Copy link
Contributor

@myronfanqiu our admin RP response for this api comes with the json format externalDNSIPAddress01, so we are in need of matching that in swagger without ignoring the case.
We ship only azure powershell/.Net SD for these azure stack administrator APIs. We do not foresee any need of shipping any other SDKs for these AZURESTACK admin specific APIs. Note that these APIs don't exist in azure. It seems like the guidance is the RP response should have got externalDnsIpAddress01 instead of externalDNSIPAddress01. Is there any doc on this guidance?(I dont see it here https://github.com/Azure/azure-resource-manager-rpc) . This change is needed for our ignite release and we are out of time to make the change at the RP code. I suggest lets merge this one to fix the powershell issue and we will track an issue internally to change the RP code if needed. Hope that makes sense

@yungezz Service team want to change two names for the case sensitive. Could you please confirm this change? This change is needed for the ignite release.

@yungezz
Copy link
Member

yungezz commented Oct 27, 2019

hi @myronfanqiu it make sense. I'm ok to merge it.

@mmyyrroonn
Copy link
Contributor

@LingyunSu Hello. Add suppression in readme.md for LintDiff and I can merge it~

Update readme to suppress build error
Update readme to suppress error
Update readme to suppress error
Update readme to suppress error
Update readme to suppress error
Update readme to suppress error
@LingyunSu
Copy link
Contributor Author

@myronfanqiu @vikasnav @JesusAlvarezTorres @bganapa after many tries, finally, I am there. :)

@mmyyrroonn
Copy link
Contributor

@LingyunSu Thanks very much!

@mmyyrroonn mmyyrroonn merged commit 7f1524d into Azure:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants