-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix miss spelling property name and case sensitive #7616
Conversation
Fix miss spelling property name externalDnsIPAddress
Case sensitive fix in Fabriclocation
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
@LingyunSu Hi. Because you do such change in the preview version, it's fine. Could you revolve the conflicts first? |
@myronfanqiu Resolved the conflicts. It is actually a bug fix that we must take. Thanks! |
@LingyunSu Hello. If you make sure that you want such change, please add suppression in the readme.file to fix LintDiff. For the Spellcheck, please add these words into https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt. Please double check the change. |
Such change may cause problems for SDK generation. externalDNSIPAddress01 will be external_d_n_s_i_p_address01 in some SDKs. |
Can you share the context about this PR? |
@myronfanqiu our admin RP response for this api comes with the json format externalDNSIPAddress01, so we are in need of matching that in swagger without ignoring the case. |
@bganapa Hello. If you make sure that you want such change, please add suppression in the readme.file to fix LintDiff. For the Spellcheck, please add these words into https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt. Fix CI so that I can merge it. |
Add new custom words for Fabriclocation model
@bganapa @myronfanqiu new custom words added. |
@LingyunSu please add suppression in the readme.file to fix LintDiff. |
@yungezz Service team want to change two names for the case sensitive. Could you please confirm this change? This change is needed for the ignite release. |
hi @myronfanqiu it make sense. I'm ok to merge it. |
@LingyunSu Hello. Add suppression in readme.md for LintDiff and I can merge it~ |
Update readme to suppress build error
Update readme to suppress error
Update readme to suppress error
Update readme to suppress error
Update readme to suppress error
Update readme to suppress error
@myronfanqiu @vikasnav @JesusAlvarezTorres @bganapa after many tries, finally, I am there. :) |
@LingyunSu Thanks very much! |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.