[TimeSeriesInsights] Query categorical variable and warm store query parameter changes #7609
Conversation
Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives.
…Prop Added dataStringComparisonBehavior parameter to reference data put/update spec
…onKeyProperty Adding partitionKeyProperty to EnvironmentCreate and EnvironmentGet request.
…lingAsString changing modelAsString for partitionKeyPRoperties
…heritance from TrackedResource.
Introduce longterm environment to TSI resource hierarchy
|
Can one of the admins verify this patch? |
|
@yeskarthik, please take a look at and fix the Avocado and spell check error. |
|
@lirenhe I fixed the comments, can you please complete the PR? Thanks. |
|
#sign-off |
|
@lirenhe can you please complete the PR? |
Please wait for ARM to signoff this PR |
|
@lirenhe this is not an ARM API, this is data access API, they usually don't sign off these changes. @deepakpalled |
|
I'm going to be adding one more minor change. |
|
@Azure/azure-api-review-board can you please verify and merge these changes? These changes are already deployed and live. These are updates the existing APIs and only swagger changes. This does not contain any SDK changes. |
Automation for azure-sdk-for-pythonEncountered a Subprocess error: (azure-sdk-for-python)
Command: ['/usr/local/bin/autorest', '/tmp/tmpxfttb9e4/rest/specification/timeseriesinsights/data-plane/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpo0frri75'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core
at main (/opt/node_modules/autorest/dist/app.js:232:19)
at <anonymous>
/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
autorest_core_1.Shutdown();
^
ReferenceError: autorest_core_1 is not defined
at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
at emitOne (events.js:121:20)
at process.emit (events.js:211:7)
at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
return binding.close(fd);
^
Error: EBADF: bad file descriptor, close
at Object.fs.closeSync (fs.js:612:18)
at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
at process._fatalException (bootstrap_node.js:391:26) |
| "description": "The list of values that a category maps to. Can be either a unique list of string or list of long.", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "object" |
There was a problem hiding this comment.
The description and swagger are in disagreement as to what the types can be here. A string or integer in swagger/openapi are not objects.
| "$ref": "#/definitions/TimeSeriesAggregateCategory" | ||
| } | ||
| }, | ||
| "defaultCategory": { |
There was a problem hiding this comment.
Is there a specific reason as to why the type of defaultCatgory is a complex object with a single attribute?
| "required": false, | ||
| "type": "string", | ||
| "x-ms-parameter-location": "method", | ||
| "description":"For the environments with warm store enabled, the query can be executed either on the 'WarmStore' or 'ColdStore'. This parameter in the query defines which store the query should be executed on. If not defined, the query will be executed on the cold store." |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.