Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new EventGrid event type for Azure Machine Learning Services #7608

Merged
merged 6 commits into from
Oct 25, 2019
Merged

Add new EventGrid event type for Azure Machine Learning Services #7608

merged 6 commits into from
Oct 25, 2019

Conversation

j-so
Copy link
Contributor

@j-so j-so commented Oct 23, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@j-so j-so requested a review from kalyanaj as a code owner October 23, 2019 21:21
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 23, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from dc469e5, Iteration 1)

Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/eventgrid [Logs]
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from anuchandy October 23, 2019 21:22
@AutorestCI AutorestCI mentioned this pull request Oct 23, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 23, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6151

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 23, 2019
Merged
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

kalyanaj
kalyanaj approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@kalyanaj kalyanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kalyanaj kalyanaj requested a review from mmyyrroonn October 24, 2019 15:49
@mmyyrroonn mmyyrroonn merged commit 1ceb5dc into Azure:master Oct 25, 2019
@AutorestCI AutorestCI mentioned this pull request Oct 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

@kalyanaj kalyanaj kalyanaj approved these changes

@mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

Assignees

@anuchandy anuchandy

@mmyyrroonn mmyyrroonn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@j-so @AutorestCI @azuresdkci @anuchandy @kalyanaj @mmyyrroonn