Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PUT and PATCH against App resource supports async #7594

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Make PUT and PATCH against App resource supports async #7594

merged 1 commit into from
Oct 24, 2019

Conversation

bowen5
Copy link
Contributor

@bowen5 bowen5 commented Oct 23, 2019 •
edited
Loading

  1. Make PUT and PATCH against App resource supports async.
  2. Remove "Processing" enum from DeploymentResourceProperties's status property.
  3. Rename "Processing" enum to "Updating" for DeploymentResourceProperties's provisioningState.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@bowen5
1. Make PUT and PATCH against App resource supports async.
980a4a3 
2. Remove "Processing" enum from DeploymentResourceProperties's status property.
3. Rename "Processing" enum to "Updating" for DeploymentResourceProperties's provisioningState.
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 23, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 980a4a3, Iteration 3)

In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Package generation in progress.
In-Progress Ruby: test-repo-billy/azure-sdk-for-ruby [Logs]
  • Package generation in progress.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 23, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6122

@AutorestCI AutorestCI mentioned this pull request Oct 23, 2019
Merged
@ArcturusZhang ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 23, 2019
@ArcturusZhang
Copy link
Member

LGTM

@yungezz yungezz removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 23, 2019
@bowen5 bowen5 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 23, 2019
@ArcturusZhang ArcturusZhang removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 24, 2019
@ArcturusZhang ArcturusZhang merged commit 191aa6f into master Oct 24, 2019
@JackTn JackTn deleted the app-platform-2019-05-01-app-async branch August 9, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

Assignees

@ArcturusZhang ArcturusZhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bowen5 @azuresdkci @AutorestCI @ArcturusZhang @yungezz