Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 2019-07-01 version for golang SDK #7592

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Update 2019-07-01 version for golang SDK #7592

merged 1 commit into from
Oct 23, 2019

Conversation

ArcturusZhang
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 23, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from b83db8b, Iteration 1)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed compute/resource-manager/v2017_03_30 [Logs] [Generation PR]
  • Failed compute/resource-manager/v2017_09_01 [Logs]
  • Failed compute/resource-manager/v2017_12_01 [Logs]
  • Failed compute/resource-manager/v2018_04_01 [Logs]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ArcturusZhang
Copy link
Member Author

This has been approved from service team in internal conversation

@AutorestCI
Copy link

AutorestCI commented Oct 23, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6124

@AutorestCI AutorestCI mentioned this pull request Oct 23, 2019
Merged
This was referenced Oct 23, 2019
Closed
Closed
@fengzhou-msft fengzhou-msft merged commit b3bbb3c into Azure:master Oct 23, 2019
@ArcturusZhang ArcturusZhang deleted the change-newest-compute-version branch October 23, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

@hyonholee hyonholee Awaiting requested review from hyonholee

Assignees

@fengzhou-msft fengzhou-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArcturusZhang @azuresdkci @AutorestCI @fengzhou-msft