Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY TO MERGE] Add new composite version for sql #7590

Merged

Conversation

ArcturusZhang
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 23, 2019

In Testing, Please Ignore

[Logs] (Generated from 7fae08b, Iteration 3)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ArcturusZhang ArcturusZhang added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 23, 2019
@ArcturusZhang ArcturusZhang changed the title Add new composite version for sql [DO NOT MERGE] Add new composite version for sql Oct 23, 2019
@ArcturusZhang
Copy link
Member Author

Please do not merge this pr, this should also be approved from the service side. We will let you know when this is ready to merge, thanks!

@AutorestCI
Copy link

AutorestCI commented Oct 23, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6141

@jaredmoo
Copy link
Contributor

Why is v2 used instead of v3?

@ArcturusZhang
Copy link
Member Author

Why is v2 used instead of v3?

I changed to v3

@ArcturusZhang ArcturusZhang changed the title [DO NOT MERGE] Add new composite version for sql [READY TO MERGE] Add new composite version for sql Oct 24, 2019
@ArcturusZhang ArcturusZhang removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 24, 2019
@weidongxu-microsoft weidongxu-microsoft merged commit 89506d9 into Azure:master Oct 24, 2019
@ArcturusZhang ArcturusZhang deleted the add-new-version-for-sql branch October 24, 2019 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants