Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viviali iotcentral new API onboarding #7570

Merged
merged 24 commits into from
Oct 25, 2019
Merged

Viviali iotcentral new API onboarding #7570

merged 24 commits into from
Oct 25, 2019

Conversation

viv-liu
Copy link
Contributor

@viv-liu viv-liu commented Oct 22, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 22, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from f338b5d, Iteration 22)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@AutorestCI
Copy link

AutorestCI commented Oct 22, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci azuresdkci requested a review from yaohaizh October 22, 2019 03:22
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yaohaizh yaohaizh added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 22, 2019
@yaohaizh
Copy link
Contributor

@ruowan do you know what kind of this error https://dev.azure.com/azure-sdk/public/_build/results?buildId=164674&view=logs&j=f10f5372-40ed-54fc-caa4-b1cb5bd1252b&t=d3b2b841-a93b-5fa5-47c3-d8c4f6eae6e3&l=258 and how to fix it?

ruowan
ruowan reviewed Oct 23, 2019
View reviewed changes
specification/iotcentral/data-plane/readme.md Outdated

# all the input files across all versions
input-file:
- $(this-folder)/preview/2019-10-28/iotcentral.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path is not correct, pls change it to
$(this-folder)/Microsoft.IoTCentral/preview/2019-10-28/iotcentral.json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ruowan this is passing now. The only remaining issue is the breaking change validation it seems oad is failing to de-serialize the swagger to do the check , but when i run the tool locally it passes fine.

@ruowan
Copy link
Member

ruowan commented Oct 23, 2019

@ruowan do you know what kind of this error https://dev.azure.com/azure-sdk/public/_build/results?buildId=164674&view=logs&j=f10f5372-40ed-54fc-caa4-b1cb5bd1252b&t=d3b2b841-a93b-5fa5-47c3-d8c4f6eae6e3&l=258 and how to fix it?

I add a comment. The input file path is not correct, so avocado can't find the input file and report these errors.

@ruowan
Copy link
Member

ruowan commented Oct 24, 2019

@qiaozha Could you please take a look at the breaking change error?

@ruowan
Copy link
Member

ruowan commented Oct 25, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@viv-liu
Copy link
Contributor Author

viv-liu commented Oct 25, 2019

We have approval from API review board @rysweet for public preview

@yaohaizh yaohaizh added AzureAPIBoardSignedOff and removed APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. labels Oct 25, 2019
@yaohaizh yaohaizh merged commit 9aaa9fa into Azure:master Oct 25, 2019
@yaohaizh
Copy link
Contributor

@viv-liu merged

@yaohaizh yaohaizh added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafarhat rafarhat rafarhat left review comments

@ruowan ruowan ruowan left review comments

@yaohaizh yaohaizh yaohaizh approved these changes

Assignees

@yaohaizh yaohaizh

Labels
APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. AzureAPIBoardSignedOff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@viv-liu @AutorestCI @azuresdkci @yaohaizh @ruowan @rafarhat