Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish container service 2019-10-01 api version #7567

Merged
merged 5 commits into from
Oct 22, 2019
Merged

Publish container service 2019-10-01 api version #7567

merged 5 commits into from
Oct 22, 2019

Conversation

xizha162
Copy link
Contributor

@xizha162 xizha162 commented Oct 21, 2019 •
edited
Loading

Latest improvements:

Included in 2019-10-01 api version:

  1. added private FQDN (PR added private FQDN #7430 )
  2. updating sdk tags (PR updating sdk tags for 2019-10-01 api version #7550 )

Both PRs have been approved. This PR is to merge from dev branch to master branch.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Xiaofang Zhang and others added 5 commits October 21, 2019 14:41
Adds base for updating Microsoft.ContainerService from version stable…
cd03564 
…/2019-08-01 to version 2019-10-01
Updates readme
8e2f8ef
Updates API version in new specs and examples
8ff44c7
@weinong
added private FQDN (Azure#7430)
2033108 
* added private FQDN

* added example

* remove example
updating sdk tags for 2019-10-01 api version (Azure#7550)
e08f7a3 
* updating sdk tags for 2019-10-01 api version

* fixing ci errors
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 21, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from e08f7a3, Iteration 1)

Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/arm-containerservice [Logs]
Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

This was referenced Oct 21, 2019
Closed
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 21, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6095

@AutorestCI AutorestCI mentioned this pull request Oct 21, 2019
Merged
@ArcturusZhang
Copy link
Member

Looks good to me, please wait for the ARM team's review

@ArcturusZhang ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 22, 2019
@ArcturusZhang ArcturusZhang merged commit cf9e1b3 into Azure:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

Assignees

@ArcturusZhang ArcturusZhang

Labels
WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xizha162 @azuresdkci @AutorestCI @ArcturusZhang @weinong