Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Db2LinkedServiceTypeProperties #7546

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Update Db2LinkedServiceTypeProperties #7546

merged 1 commit into from
Oct 25, 2019

Conversation

Jingshu923
Copy link
Contributor

@Jingshu923 Jingshu923 commented Oct 18, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 18, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 2bf8ae4, Iteration 6)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.

@AutorestCI AutorestCI mentioned this pull request Oct 18, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 18, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7962

@AutorestCI AutorestCI mentioned this pull request Oct 18, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 18, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6153

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@weidongxu-microsoft weidongxu-microsoft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 18, 2019
@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 22, 2019
@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Oct 23, 2019 •
edited
Loading

@anthony-c-martin

Hello, if you are OK with Jianshu's explanation would you change the review status to Approve (I think currently it is Request Change), so I could merge the PR? Thanks.

@weidongxu-microsoft weidongxu-microsoft merged commit c591bd7 into Azure:master Oct 25, 2019
@AutorestCI AutorestCI mentioned this pull request Oct 25, 2019
Merged
This was referenced Nov 11, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

Assignees

@weidongxu-microsoft weidongxu-microsoft

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jingshu923 @AutorestCI @azuresdkci @weidongxu-microsoft @anthony-c-martin @Jingshu918