Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventGrid: New preview API version with support for additional destination types, CloudEvents 1.0, and batching support. #7527

Merged
merged 7 commits into from
Oct 23, 2019
Merged

EventGrid: New preview API version with support for additional destination types, CloudEvents 1.0, and batching support. #7527

merged 7 commits into from
Oct 23, 2019

Conversation

kalyanaj
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • [] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@kalyanaj kalyanaj added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 16, 2019
@kalyanaj kalyanaj requested a review from sarangan12 October 16, 2019 21:23
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 16, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 227d311, Iteration 5)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • No packages generated.
Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs]
  • No packages generated.
Failed Go: test-repo-billy/azure-sdk-for-go [Logs]
  • No packages generated.
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • No packages generated.
Failed Ruby: test-repo-billy/azure-sdk-for-ruby [Logs]
  • No packages generated.

@AutorestCI AutorestCI mentioned this pull request Oct 16, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8072

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6117

This was referenced Oct 16, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@kalyanaj
Copy link
Contributor Author

Commit 1 is an exact snapshot of the last preview API version (2019-02-01-preview) to make diffs easier. Hence, the main changes are in commits 2, 3, 4. Commit 5 is a change to merge the changes already done in our last GA version (2019-06-01) into this new preview API version.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

KrisBash
KrisBash approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...ion/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-01-01-preview/EventGrid.json
@@ -2767,6 +2751,20 @@
"description": "The base URL that represents the endpoint of the destination of an event subscription.",
"type": "string",
"readOnly": true
},
"maxEventsPerBatch": {
"format": "int32",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there min/max values that could be defined in swagger?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Currently the limits are enforced by our RP. Once we close on the exact values, we will add the min/max values in swagger for our stable version.

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 17, 2019
KrisBash
KrisBash approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yungezz yungezz closed this Oct 21, 2019
@yungezz yungezz reopened this Oct 21, 2019
This was referenced Oct 21, 2019
Closed
Merged
@yungezz
Copy link
Member

yungezz commented Oct 21, 2019

hi @ruowan could you pls help to look at what's the avocado error?

@ruowan
Copy link
Member

ruowan commented Oct 21, 2019

Hi, @kalyanaj For avocado validation error. You need to add /specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-01-01-preview/EventGrid.json to your readme file as an input file. Because if the readme doesn't contain this file, then SDK will not be generated and avocado report UNREFERENCED_JSON_FILE error.

This was referenced Oct 21, 2019
Merged
Merged
Merged
Merged
Merged
Merged
@AutorestCI AutorestCI mentioned this pull request Oct 21, 2019
Merged
@kalyanaj
Copy link
Contributor Author

Thanks @ruowan for the info! I have updated the README files now and CI is green now. Please let me know if you have any additional feedback Can you please help review/merge this PR?

@kalyanaj kalyanaj requested review from ruowan and yungezz October 22, 2019 22:39
@yungezz yungezz merged commit 1698503 into Azure:master Oct 23, 2019
@kalyanaj kalyanaj deleted the master branch October 23, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12

@ruowan ruowan Awaiting requested review from ruowan

@yungezz yungezz Awaiting requested review from yungezz

Assignees

@sarangan12 sarangan12

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kalyanaj @AutorestCI @azuresdkci @yungezz @ruowan @KrisBash @sarangan12