Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-event-schema-for-azure-storage-event-grid-notification-for-cr… #7509

Merged
merged 4 commits into from
Oct 22, 2019
Merged

update-event-schema-for-azure-storage-event-grid-notification-for-cr… #7509

merged 4 commits into from
Oct 22, 2019

Conversation

wanha-ms
Copy link
Contributor

…eate-delete-directory-and-rename-blob-directory

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@wanha-ms
update-event-schema-for-azure-storage-event-grid-notification-for-cr…
428c006 
…eate-delete-directory-and-rename-blob-directory
@wanha-ms wanha-ms requested a review from kalyanaj as a code owner October 15, 2019 23:03
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 15, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 74a61c2, Iteration 5)

Failed Go: test-repo-billy/azure-sdk-for-go [Logs]
  • No packages generated.
Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • No packages generated.
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@msftclas
Copy link

msftclas commented Oct 15, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@azuresdkci azuresdkci requested a review from mmyyrroonn October 15, 2019 23:04
@AutorestCI AutorestCI mentioned this pull request Oct 15, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 15, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpgo7fmh__/rest/specification/eventgrid/data-plane/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpgo7fmh__/sdk/sdk', '--use=@microsoft.azure/autorest.python@~4.0.71', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4405)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~4.0.71->4.0.71)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
ERROR: Schema violation: Data does not match any schemas from 'anyOf'
    - file:///tmp/tmpgo7fmh__/rest/specification/eventgrid/data-plane/Microsoft.Storage/stable/2018-01-01/Storage.json:168:10 ($.definitions.StorageDirectoryDeletedEventData.properties.recursive.type)
FATAL: swagger-document/individual/schema-validator - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Oct 15, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 15, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6105

kalyanaj
kalyanaj requested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@kalyanaj kalyanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added my feedback, can you please take a look?

@mmyyrroonn mmyyrroonn added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Oct 16, 2019
@wanha-ms
Copy link
Contributor Author

wanha-ms commented Oct 17, 2019 via email

@wanha-ms
Copy link
Contributor Author

wanha-ms commented Oct 17, 2019 via email

kalyanaj
kalyanaj approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@kalyanaj kalyanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wanha-ms
Copy link
Contributor Author

wanha-ms commented Oct 17, 2019 via email

@wanha-ms
Copy link
Contributor Author

wanha-ms commented Oct 17, 2019 via email

@wanha-ms
Copy link
Contributor Author

wanha-ms commented Oct 17, 2019 via email

@mmyyrroonn mmyyrroonn closed this Oct 21, 2019
@mmyyrroonn mmyyrroonn reopened this Oct 21, 2019
@mmyyrroonn
Copy link
Contributor

@wanha-ms Hello. Could you fix the errors in LintDiff and Semantic? @NullMDR Hi. Could you help us take a look at SDK's failures?

@PhoenixHe-NV
Copy link
Contributor

@myronfanqiu The semantic failure should be fixed first to get sdk generation pass.

@wanha-ms
Copy link
Contributor Author

wanha-ms commented Oct 21, 2019 via email

@wanha-ms
Copy link
Contributor Author

wanha-ms commented Oct 21, 2019 via email

@mmyyrroonn mmyyrroonn merged commit 6405fdd into Azure:master Oct 22, 2019
@wanha-ms wanha-ms deleted the update-event-schema-for-azure-storage-event-grid-notification branch October 22, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yungezz yungezz yungezz left review comments

@kalyanaj kalyanaj kalyanaj approved these changes

@mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

Assignees

@mmyyrroonn mmyyrroonn

Labels
APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wanha-ms @msftclas @AutorestCI @azuresdkci @mmyyrroonn @PhoenixHe-NV @kalyanaj @yungezz