Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serial console swagger #7444

Merged
merged 9 commits into from
Oct 29, 2019
Merged

Update serial console swagger #7444

merged 9 commits into from
Oct 29, 2019

Conversation

asinn826
Copy link
Contributor

@asinn826 asinn826 commented Oct 9, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • [X ] I have reviewed the documentation for the workflow.
  • [X ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • [X ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • [X ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • [X ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 9, 2019

In Testing, Please Ignore

[Logs] (Generated from 36f34b4, Iteration 6)

Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.

@AutorestCI
Copy link

AutorestCI commented Oct 9, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#7894

@AutorestCI
Copy link

AutorestCI commented Oct 9, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6182

@asinn826
Copy link
Contributor Author

asinn826 commented Oct 9, 2019

@CraigWiand @rebekahHess - fyi

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@zikalino zikalino self-assigned this Oct 11, 2019
}
}
}
}
},
"definitions": {
"SerialConsoleGetResult": {
"GetSerialConsoleDisabledResult": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we just call it SerialConsoleStatus?

if it's called GetSerialConsoleDisabledResult, the structure with such name will appear in SDK with just one boolean parameter called "disabled"

@zikalino
Copy link

@asinn826 in general all of these fixes look very good.
I just added one comment. I think it would be good to fix it now.
I can of course fix it while generating Python SDK later.

@asinn826
Copy link
Contributor Author

@zikalino made the change you requested, thanks for the feedback!

@asinn826
Copy link
Contributor Author

@zikalino - Hey Zim, bumping this up your notifications, could you merge this in when you get a chance? Thanks!

@zikalino zikalino merged commit b60da39 into Azure:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants