-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update serial console swagger #7444
Conversation
In Testing, Please Ignore[Logs] (Generated from 36f34b4, Iteration 6)
|
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
@CraigWiand @rebekahHess - fyi |
Can one of the admins verify this patch? |
...ource-manager/Microsoft.SerialConsole/stable/2018-05-01/examples/DisableConsoleExamples.json
Outdated
Show resolved
Hide resolved
.../serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json
Show resolved
Hide resolved
.../serialconsole/resource-manager/Microsoft.SerialConsole/stable/2018-05-01/serialconsole.json
Outdated
Show resolved
Hide resolved
} | ||
} | ||
} | ||
} | ||
}, | ||
"definitions": { | ||
"SerialConsoleGetResult": { | ||
"GetSerialConsoleDisabledResult": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we just call it SerialConsoleStatus?
if it's called GetSerialConsoleDisabledResult, the structure with such name will appear in SDK with just one boolean parameter called "disabled"
@asinn826 in general all of these fixes look very good. |
…te example accordingly
@zikalino made the change you requested, thanks for the feedback! |
@zikalino - Hey Zim, bumping this up your notifications, could you merge this in when you get a chance? Thanks! |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.