Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Maps Adding missing readonly properties and examples #7428

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Microsoft.Maps Adding missing readonly properties and examples #7428

merged 1 commit into from
Oct 22, 2019

Conversation

stack111
Copy link
Contributor

@stack111 stack111 commented Oct 8, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

See the approval for specs-pr repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/942

@stack111 stack111 self-assigned this Oct 8, 2019
@AutorestCI
Copy link

AutorestCI commented Oct 8, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Oct 8, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@stack111 stack111 requested a review from KrisBash October 8, 2019 19:24
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@stack111 stack111 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 11, 2019
KrisBash
KrisBash approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 16, 2019
@yungezz yungezz self-assigned this Oct 22, 2019
@yungezz yungezz merged commit d6484d8 into dev-maps-Microsoft.Maps-2018-05-01 Oct 22, 2019
@stack111 stack111 deleted the users/dstack/specschanges branch October 22, 2019 23:34
@stack111 stack111 restored the users/dstack/specschanges branch October 23, 2019 20:36
@stack111 stack111 deleted the users/dstack/specschanges branch October 23, 2019 20:37
@stack111 stack111 mentioned this pull request Oct 24, 2019
Merged
5 tasks
yungezz pushed a commit that referenced this pull request Oct 25, 2019
@stack111 @yungezz
adding missing readonly property (#7428) (#7606)
01cfd59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@yungezz yungezz yungezz approved these changes

Assignees

@stack111 stack111

@yungezz yungezz

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stack111 @AutorestCI @azuresdkci @KrisBash @yungezz