Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new Api version 2019-08-01 #7406

Merged
merged 17 commits into from
Oct 8, 2019
Merged

Introduce new Api version 2019-08-01 #7406

merged 17 commits into from
Oct 8, 2019

Conversation

naveedaz
Copy link
Contributor

@naveedaz naveedaz commented Oct 5, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 5, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 4b1813e, Iteration 18)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Oct 5, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5972

@AutorestCI
Copy link

AutorestCI commented Oct 5, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7682

@azuresdkci azuresdkci requested a review from tjprescott October 5, 2019 09:14
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

nschonni
nschonni reviewed Oct 5, 2019
View reviewed changes
@tjprescott tjprescott added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 7, 2019
This was referenced Oct 7, 2019
Merged
Merged
Merged
Merged
@naveedaz
Copy link
Contributor Author

naveedaz commented Oct 8, 2019

@tjprescott Can you help figure out why SDK javascript and SDK python failed? SDK Java is still in progress, so not sure if it will fail too.

@AutorestCI AutorestCI mentioned this pull request Oct 8, 2019
Merged
@naveedaz
Copy link
Contributor Author

naveedaz commented Oct 8, 2019

@tjprescott Nevermind. I believe I figured out all the issues. Please review.

@AutorestCI AutorestCI mentioned this pull request Oct 8, 2019
Merged
KrisBash
KrisBash approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes from prior version LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 8, 2019
@tjprescott tjprescott merged commit 40ae0b5 into Azure:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@tjprescott tjprescott tjprescott approved these changes

@KrisBash KrisBash KrisBash approved these changes

Assignees

@ravbhatnagar ravbhatnagar

@tjprescott tjprescott

@KrisBash KrisBash

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@naveedaz @AutorestCI @azuresdkci @nschonni @tjprescott @KrisBash @ravbhatnagar