Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images swagger #7396

Merged
merged 7 commits into from
Dec 3, 2019
Merged

Images swagger #7396

merged 7 commits into from
Dec 3, 2019

Conversation

cakarata
Copy link
Contributor

@cakarata cakarata commented Oct 4, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 4, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 5a1c4c4, Iteration 1)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • No packages generated.
Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed compute/resource-manager/v2017_03_30 [Logs] [Generation PR]
  • Failed compute/resource-manager/v2017_09_01 [Logs]
  • Failed compute/resource-manager/v2017_12_01 [Logs]
  • Failed compute/resource-manager/v2018_04_01 [Logs]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • No packages generated.
Failed Go: test-repo-billy/azure-sdk-for-go [Logs]
  • No packages generated.
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Oct 4, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6478

@AutorestCI
Copy link

AutorestCI commented Oct 4, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8691

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 4, 2019
Closed
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from tjprescott October 4, 2019 01:33
@tjprescott
Copy link
Member

The diff here is pretty confusing. Other than adding ZoneResilient to various examples, has anything functional changed?

@cakarata
Copy link
Contributor Author

The diff here is pretty confusing. Other than adding ZoneResilient to various examples, has anything functional changed?

Not functional changes mostly examples are added to cover ZoneResillient field and some descriptions

@tjprescott
Copy link
Member

tjprescott commented Oct 24, 2019 •
edited
Loading

@cakarata approved but I cannot merge this due to all the failing CI checks.

@tjprescott
Copy link
Member

@cakarata please address the CI failures.

@tjprescott
Copy link
Member

/azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@tjprescott
Copy link
Member

ping @cakarata

@tjprescott tjprescott removed their assignment Nov 22, 2019
This was referenced Dec 3, 2019
Merged
Merged
Cagdas Karatas added 2 commits December 2, 2019 18:53
@cakarata
Copy link
Contributor Author

cakarata commented Dec 3, 2019

@huangpf, @hyonholee, and @tjprescott I have finally resolved the CI errors could you please review it?

@tjprescott tjprescott merged commit df4187f into Azure:master Dec 3, 2019
@hyonholee hyonholee mentioned this pull request Dec 3, 2019
Merged
5 tasks
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@cakarata @AnuTalluri
Images swagger (Azure#7396)
74856df 
* Images swagger improvements

* fixes

* fixes

* missing example file

* fixes

* fixes

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjprescott tjprescott tjprescott approved these changes

@huangpf huangpf Awaiting requested review from huangpf

@hyonholee hyonholee Awaiting requested review from hyonholee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cakarata @AutorestCI @azuresdkci @tjprescott