Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getting agent pool available versions api path #7217

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

xizha162
Copy link
Contributor

Accidentally included agent pool in the path for getting available agent pool versions API. This API is expected to be called before agent pool creation. So should not include agent pool name in the path.
(The server side implementation is correct and no changed is needed. Only update the swagger to match the implementation.)

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2019

In Testing, Please Ignore

[Logs] (Generated from 96e53c8, Iteration 1)

Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Sep 16, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7367

@AutorestCI
Copy link

AutorestCI commented Sep 16, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5833

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yaohaizh yaohaizh added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2019
@yaohaizh yaohaizh requested a review from yangl900 September 16, 2019 05:20
@yaohaizh
Copy link
Contributor

@yangl900 please help review the change as code owner. Thanks.

Copy link
Contributor

@yangl900 yangl900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off for ARM. OK with the breaking change on the basis of this being a bug fix in swagger

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 18, 2019
@yaohaizh yaohaizh merged commit 6e3da74 into Azure:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants