Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add purge API details. #7157

Merged
merged 4 commits into from
Sep 16, 2019
Merged

Add purge API details. #7157

merged 4 commits into from
Sep 16, 2019

Conversation

yoramsinger
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci azuresdkci requested a review from anuchandy September 9, 2019 11:16
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from cf0d039, Iteration 4)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed applicationinsights/resource-manager/v2015_05_01 [Logs]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Sep 9, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 9, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7272

@AutorestCI AutorestCI mentioned this pull request Sep 9, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 9, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5777

This was referenced Sep 9, 2019
Merged
Closed
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 10, 2019
anuchandy
anuchandy reviewed Sep 10, 2019
View reviewed changes
...nsights/resource-manager/Microsoft.Insights/stable/2015-05-01/examples/ComponentsCreate.json
@@ -5,7 +5,6 @@
"resourceGroupName": "my-resource-group",
"resourceName": "my-component",
"InsightProperties": {
"name": "my-component",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of model property is a breaking change and requires ARM approval. Requesting ARM review.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuchandy this appears to be in examples only? I assume this is correcting a spurious property in the example. I don't see a concerning change in the swagger spec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a removal of a read only property from the put example. It just shouldn't be there.

KrisBash
KrisBash approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...nsights/resource-manager/Microsoft.Insights/stable/2015-05-01/examples/ComponentsCreate.json
@@ -5,7 +5,6 @@
"resourceGroupName": "my-resource-group",
"resourceName": "my-component",
"InsightProperties": {
"name": "my-component",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuchandy this appears to be in examples only? I assume this is correcting a spurious property in the example. I don't see a concerning change in the swagger spec

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 13, 2019
@AutorestCI AutorestCI mentioned this pull request Sep 15, 2019
Merged
@yungezz
Copy link
Member

yungezz commented Sep 16, 2019

hi @yoramsinger is this PR ready to merge? checked CI passed in azure pipeline https://github.com/Azure/azure-rest-api-specs/pull/7157/checks?check_run_id=222699474

@yoramsinger
Copy link
Contributor Author

Ready to merge. Thanks!

@yungezz yungezz merged commit e0d9ceb into Azure:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy left review comments

@KrisBash KrisBash KrisBash approved these changes

Assignees

@anuchandy anuchandy

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yoramsinger @AutorestCI @azuresdkci @yungezz @anuchandy @KrisBash