Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Network to add version stable/2019-03-01 #6944

Merged
merged 1 commit into from
Aug 28, 2019
Merged

[Hub Generated] Review request for Microsoft.Network to add version stable/2019-03-01 #6944

merged 1 commit into from
Aug 28, 2019

Conversation

disreedh
Copy link
Contributor

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from adca4cd, Iteration 2)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azuresdkci azuresdkci requested a review from zikalino August 13, 2019 18:22
@AutorestCI AutorestCI mentioned this pull request Aug 13, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 13, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6912

@AutorestCI AutorestCI mentioned this pull request Aug 13, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 13, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5638

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 13, 2019
Closed
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@PhoenixHe-NV PhoenixHe-NV mentioned this pull request Aug 16, 2019
Closed
@zikalino
Copy link

@disreedh just noticed, this pr is to master, should be to network release branch, could you pls retarget?

@anton-evseev
Copy link
Contributor

@zikalino I don't think it should go to network release branch since it's a change in specification/frontdoor
@MikhailTryakhov please take a look

@MikhailTryakhov
Copy link
Contributor

frontdoor lives it's own lives :) so it can be merged whatever they want

@zikalino zikalino closed this Aug 22, 2019
@zikalino zikalino reopened this Aug 22, 2019
@AutorestCI AutorestCI mentioned this pull request Aug 22, 2019
Merged
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 22, 2019
Closed
@yungezz
Copy link
Member

yungezz commented Aug 28, 2019

Hi @zikalino is this PR ok to merge? if yes, can you pls merge it?

@zikalino zikalino merged commit 08e29ab into Azure:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zikalino zikalino zikalino approved these changes

Assignees

@zikalino zikalino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@disreedh @AutorestCI @azuresdkci @zikalino @anton-evseev @MikhailTryakhov @yungezz