Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SRP] Add Support for File Service and File Shares #6892

Merged
merged 5 commits into from
Aug 9, 2019
Merged

[SRP] Add Support for File Service and File Shares #6892

merged 5 commits into from
Aug 9, 2019

Conversation

zfchen95
Copy link
Contributor

@zfchen95 zfchen95 commented Aug 7, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 7, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 5d53b81, Iteration 2)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
Failed Go: test-repo-billy/azure-sdk-for-go [Logs]
  • No packages generated.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5483

@azuresdkci azuresdkci requested a review from tjprescott August 7, 2019 18:38
@AutorestCI
Copy link

AutorestCI commented Aug 7, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6382

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@zfchen95
Copy link
Contributor Author

zfchen95 commented Aug 7, 2019

The PR was approved in https://github.com/Azure/azure-rest-api-specs-pr/pull/744

This was referenced Aug 8, 2019
Merged
Merged
@tjprescott tjprescott merged commit 153962d into Azure:master Aug 9, 2019
@blueww blueww mentioned this pull request Aug 22, 2019
Merged
5 tasks
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
@phantomfiance2
[Hub Generated] Review request for Microsoft.ApiSecurity to add versi…
bbc6835 
…on preview/2022-03-02-privatepreview (Azure#6892)

* update host property

* add apiCollectionsMeta RP endpoint

* fix apiCollectionsMeta example

* fix Prettier check

* Revert "fix Prettier check"

This reverts commit 226169ff3a8744a1e9925709942b84411369b5fa.

* fix Prettier check again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjprescott tjprescott tjprescott approved these changes

Assignees

@tjprescott tjprescott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zfchen95 @AutorestCI @azuresdkci @tjprescott