Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiskRP Swagger changes for 2019-03-01 #6824

Merged
merged 20 commits into from
Aug 21, 2019
Merged

DiskRP Swagger changes for 2019-03-01 #6824

merged 20 commits into from
Aug 21, 2019

Conversation

realschwa
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 31, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 4f5dbad, Iteration 6)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Warning Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Warning compute/resource-manager/v2017_03_30 [Logs]
  • Warning compute/resource-manager/v2017_09_01 [Logs]
  • Warning compute/resource-manager/v2017_12_01 [Logs]
  • Warning compute/resource-manager/v2018_04_01 [Logs]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning compute/mgmt/2015-06-15 [Logs]
  • Warning compute/mgmt/2016-03-30 [Logs]
  • Warning compute/mgmt/2017-03-30 [Logs]
  • Warning compute/mgmt/2017-09-01 [Logs]
  • Warning compute/mgmt/2017-12-01 [Logs]
  • Warning compute/mgmt/2018-04-01 [Logs]
  • Warning compute/mgmt/2018-06-01 [Logs]
  • Warning compute/mgmt/2018-10-01 [Logs]
  • Failed compute/mgmt/2019-03-01 [Logs] [Instructions]
  • Warning compute/mgmt/2019-07-01 [Logs]
  • Warning containerservice/mgmt/2016-03-30 [Logs]
  • Warning containerservice/mgmt/2016-09-30 [Logs]
  • Warning containerservice/mgmt/2017-01-31 [Logs]
  • Warning preview/compute/mgmt/2016-04-30-preview [Logs]
  • Warning preview/containerservice/mgmt/2015-11-01-preview [Logs]
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from jhendrixMSFT July 31, 2019 20:23
@realschwa
Copy link
Contributor Author

Some of the changes in this PR were already reviewed here https://github.com/Azure/azure-rest-api-specs-pr/pull/818

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI AutorestCI mentioned this pull request Jul 31, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 31, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5579

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 31, 2019
Closed
This was referenced Jul 31, 2019
Closed
Closed
Closed
Closed
@jhendrixMSFT
Copy link
Member

Which commits contain new content not reviewed in the PR from the private repo?

@realschwa
Copy link
Contributor Author

Which commits contain new content not reviewed in the PR from the private repo?
@jhendrixMSFT
Commits starting with 8ff7131 (adding diskSizeBytes to disk.json) and forward, are not present in the PR in the private repo.

@jhendrixMSFT
Copy link
Member

Changes look good, are we just waiting for this to be deployed?

@realschwa
Copy link
Contributor Author

realschwa commented Aug 7, 2019 •
edited
Loading

Changes look good, are we just waiting for this to be deployed?

@jhendrixMSFT Yeah the changes aren't deployed yet. We're aiming to start a deployment today. I will let you know when everything is good

vikramd-ms
vikramd-ms reviewed Aug 9, 2019
View reviewed changes
Copy link

@vikramd-ms vikramd-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non Incremental -> non-incremental

Josh Pollock added 20 commits August 12, 2019 15:39
commit with 2018-09-30 files
1a3b855
incremental snapshots going in disk.json
98fb32a
adding incremental examples
0191abc
upload size bytes and incremental snapshots
4ecfe7e
adding diskSizeBytes to disk.json
b3eab8a
adding descriptions to the disk create option enums
42d4d47
adding diskSizeBytes as a read only field
4392216
adding encryptionSettingsVersion
2ab39f4
updating readme
220870d
add example
a86e712
removing extra descriptions
08104b7
Revert "removing extra descriptions"
28426c9 
This reverts commit 3a0f6498ff6d12663a4929cc78d05911112124c7.
adding enum descriptions back in
8092047
adding descriptions for some enums
46abb4f
fixing incorrect use of name and replacing it with the correct proper…
f50af6e 
…ty value
adding unique id
8fbcc52
fixing the snapshots examples so that model validation passes - don't…
b94cde6 
… send a read only field in the request
fixing typo
8fccdbb
removing diskSizeBytes from snapshot\disk update properties and addin…
e46fd65 
…g a unique id for disk properties
pr comments
4f5dbad
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 12, 2019
Merged
@jhendrixMSFT
Copy link
Member

@pollock4595 hello just checking on status of this PR.

@realschwa
Copy link
Contributor Author

@jhendrixMSFT the deployment still hasn't completed yet :(

I will let you know when it is done and safe to merge!

@realschwa realschwa changed the title [Do not merge yet] DiskRP Swagger changes for 2019-03-01 DiskRP Swagger changes for 2019-03-01 Aug 21, 2019
@realschwa
Copy link
Contributor Author

@jhendrixMSFT the deployment is completed, so it's safe to merge now

@jhendrixMSFT jhendrixMSFT merged commit 99947a4 into Azure:master Aug 21, 2019
@realschwa realschwa mentioned this pull request Aug 21, 2019
Merged
@yaohaizh yaohaizh mentioned this pull request Aug 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@vikramd-ms vikramd-ms vikramd-ms left review comments

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@huangpf huangpf Awaiting requested review from huangpf

@hyonholee hyonholee Awaiting requested review from hyonholee

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@realschwa @AutorestCI @azuresdkci @jhendrixMSFT @nschonni @vikramd-ms