Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add HyperVGeneation in GetVMImage #6730

Merged
merged 2 commits into from
Aug 5, 2019
Merged

add HyperVGeneation in GetVMImage #6730

merged 2 commits into from
Aug 5, 2019

Conversation

khan15
Copy link
Contributor

@khan15 khan15 commented Jul 25, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@khan15 khan15 requested review from huangpf and hyonholee as code owners July 25, 2019 23:54
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 25, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from c34793b, Iteration 3)

Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@azuresdkci azuresdkci requested a review from erich-wang July 25, 2019 23:55
@AutorestCI AutorestCI mentioned this pull request Jul 25, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 25, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6461

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jul 26, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 26, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5430

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 26, 2019
Closed
This was referenced Jul 26, 2019
Merged
Merged
Merged
Merged
@PhoenixHe-NV
Copy link
Contributor

@OpenAPIBot sdkautomation rebuild

@erich-wang erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 26, 2019
@hyonholee
Copy link
Contributor

LGTM

majastrz
majastrz reviewed Jul 30, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that the new property is read-only?

@hyonholee
Copy link
Contributor

hyonholee commented Aug 1, 2019 •
edited
Loading

This property only appears in response body. So we don't need to set it as read-only, right?

@majastrz
Copy link
Member

majastrz commented Aug 2, 2019

This property only appears in response body. So we don't need to set it as read-only, right?

Yeah, that's fine. I was asking the question to confirm that this is not a breaking change. Based on your answer (it only shows up on GET responses), it's not a breaking change.

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 2, 2019
majastrz
majastrz approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off from ARM side.

@erich-wang erich-wang merged commit 1b5c6d9 into Azure:master Aug 5, 2019
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
@panesar-msft @varunjain-github
Added Private Endpoint configuration for Customer Claimsprovider (Azu…
0bb5686 
…re#6730)

* Added EnablePrivateEndpointConnection flag for customer extensions in MCVP

* Fix style/prettier

* Added PrivateEndpoint config for Claimsprovider

* Update connectedvehicle.json

* remove newline at the end of file

* rename to privateLinkResource

* fix spelling

* Update connectedvehicle.json

Co-authored-by: Varun Jain <vajain@microsoft.com>
Co-authored-by: varunjain-github <68244433+varunjain-github@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyonholee hyonholee hyonholee left review comments

@majastrz majastrz majastrz approved these changes

@huangpf huangpf Awaiting requested review from huangpf

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@erich-wang erich-wang

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@khan15 @AutorestCI @azuresdkci @PhoenixHe-NV @hyonholee @majastrz @erich-wang @gitjhan