Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] [SRP] Fix existing build errors in Storage swagger #6611

Closed
wants to merge 4 commits into from

Conversation

zfchen95
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Jul 12, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 12, 2019

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 12, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@zfchen95 zfchen95 changed the title [Do not merge] [SRP] Fix existing errors in Storage swagger [SRP] Fix existing errors in Storage swagger Jul 12, 2019
@zfchen95 zfchen95 changed the title [SRP] Fix existing errors in Storage swagger [SRP] Fix existing build errors in Storage swagger Jul 12, 2019
@nschonni
Copy link
Contributor

I think the fix might be to clear out the empty body instead. EX:

  "responses": {
    "200": {
      "body": ""
    },
    "204": {
      "body": ""
    }

becomes

  "responses": {
    "200": {},
    "204": {}

@zfchen95
Copy link
Contributor Author

I think the fix might be to clear out the empty body instead. EX:

  "responses": {
    "200": {
      "body": ""
    },
    "204": {
      "body": ""
    }

becomes

  "responses": {
    "200": {},
    "204": {}

Make sense to me. Updated the PR.

@nschonni
Copy link
Contributor

PS: might have the same problem in a few of the older examples too that might be worth fixing

@zfchen95
Copy link
Contributor Author

PS: might have the same problem in a few of the older examples too that might be worth fixing

Fixed the rest "empty body" issues.

@zfchen95 zfchen95 changed the title [SRP] Fix existing build errors in Storage swagger [Do not merge] [SRP] Fix existing build errors in Storage swagger Jul 15, 2019
@zfchen95 zfchen95 closed this Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants