Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional billing profile to VMSS Create and Update APIs for Api Version 2019-03-01 #6492

Closed
wants to merge 2 commits into from
Closed

Adding optional billing profile to VMSS Create and Update APIs for Api Version 2019-03-01 #6492

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
055b2ad
Adding optional billing profile to VMSS Set and Update APIs for Api V…
rakeshakkera Jun 27, 2019
4d339d3
Added propeties block for Billing profile and put max price in it
rakeshakkera Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6208,6 +6208,14 @@
},
"description": "Specifies the boot diagnostic settings state. <br><br>Minimum api-version: 2015-06-15."
},
"BillingProfile": {
"maxPrice": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this property to inside of "properties":

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing out. This was causing the error initially. Made the change.

"type": "number",
"format": "double",
"description": "Specifies the maximum price you are willing to pay for a low priority VM/VMSS. This price is in US Dollars. <br><br> This price will be compared with the current low priority price for the VM size. Also, the prices are compared at the time of create/update of low priority VM/VMSS and the operation will only succeed if the maxPrice is greater than the current low priority price. <br><br> The maxPrice will also be used for evicting a low priority VM/VMSS if the current low priority price goes beyond the maxPrice after creation of VM/VMSS. <br><br> Possible values are: <br><br> - Any decimal value greater than zero. Example: $0.01538 <br><br> -1 – indicates default price to be up-to on-demand. <br><br> You can set the maxPrice to -1 to indicate that the low priority VM/VMSS should not be evicted for price reasons. Also, the default max price is -1 if it is not provided by you. <br><br>Minimum api-version: 2019-03-01."
},
"description": "Specifies the billing related details of a low priority VM or VMSS. <br><br>Minimum api-version: 2019-03-01."
},
"VirtualMachineExtensionHandlerInstanceView": {
"properties": {
"type": {
Expand Down Expand Up @@ -7726,6 +7734,10 @@
"name": "VirtualMachineEvictionPolicyTypes",
"modelAsString": true
}
},
"billingProfile": {
"$ref": "#/definitions/BillingProfile",
"description": "Specifies the billing related details of a low priority VMSS. <br><br>Minimum api-version: 2019-03-01."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need description here. It seems exactly the same as in referred type definition.

}
},
"description": "Describes a virtual machine scale set virtual machine profile."
Expand Down Expand Up @@ -7755,6 +7767,10 @@
"licenseType": {
"type": "string",
"description": "The license type, which is for bring your own license scenario."
},
"billingProfile": {
"$ref": "#/definitions/BillingProfile",
"description": "Specifies the billing related details of a low priority VMSS. <br><br>Minimum api-version: 2019-03-01."
}
},
"description": "Describes a virtual machine scale set virtual machine profile."
Expand Down